You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/09/28 16:51:13 UTC

[GitHub] narinearraul commented on a change in pull request #243: WIP: parameterize host name and edge host

narinearraul commented on a change in pull request #243: WIP: parameterize host name and edge host
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/243#discussion_r141674854
 
 

 ##########
 File path: packages/installCatalog.sh
 ##########
 @@ -8,11 +8,11 @@
 SCRIPTDIR="$(cd $(dirname "$0")/ && pwd)"
 OPENWHISK_HOME=${OPENWHISK_HOME:-$SCRIPTDIR/../../openwhisk}
 
-source "$SCRIPTDIR/validateParameter.sh" $1 $2 $3
-: ${WHISK_SYSTEM_AUTH:?"WHISK_SYSTEM_AUTH is not configured. Please input the correctly parameter: CATALOG_AUTH_KEY"}
-: ${WHISK_API_HOST:?"WHISK_API_HOST is not configured. Please input the correctly parameter: API_HOST"}
-: ${WHISK_CLI_PATH:?"WHISK_CLI_PATH is not configured. Please input the correctly parameter: cli_path"}
-
+source "$SCRIPTDIR/validateParameter.sh" $1 $2 $3 $4 $5
+: ${WHISK_SYSTEM_AUTH:?"WHISK_SYSTEM_AUTH is not configured. Please input the correct parameter: CATALOG_AUTH_KEY"}
+: ${WHISK_EDGE_HOST:?"WHISK_EDGE_HOST is not configured. Please input the correct parameter: API_HOST"}
 
 Review comment:
   oh i see, a bit confused on the namings. This is a duplicate for https://github.com/apache/incubator-openwhisk-catalog/pull/230 and I was reading the comments there. Trying to debug some failures on the existing PR. 
   
   Looks like in that one WHISK_API_HOST was replaced by WHISK_EDGE_HOST (naming wise) Should this not have been the case?
    
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services