[GitHub] srkukarni commented on a change in pull request #1751: Allow ability to specify resources to functions

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #1751: Allow ability to specify resources to functions
URL: https://github.com/apache/incubator-pulsar/pull/1751#discussion_r187372630
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
 ##########
 @@ -316,6 +323,23 @@ void processArguments() throws Exception {
                 functionConfig.setParallelism(num);
             }
 
+            if (cpu != null) {
+                if (cpu <= 0) {
+                    throw new IllegalArgumentException("The cpu allocation for the function must be positive");
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services