You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by ka...@apache.org on 2020/06/15 03:07:52 UTC
[fineract] branch develop updated: FINERACT-821 Added and Enforced
EmptyLineSeparator Checkstyle
This is an automated email from the ASF dual-hosted git repository.
kaze pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 8aab991 FINERACT-821 Added and Enforced EmptyLineSeparator Checkstyle
8aab991 is described below
commit 8aab991194bf5eb0acc62a70fa09d59cf8db7cee
Author: thesmallstar <ma...@gmail.com>
AuthorDate: Mon Jun 15 06:23:30 2020 +0530
FINERACT-821 Added and Enforced EmptyLineSeparator Checkstyle
---
fineract-provider/config/checkstyle/checkstyle.xml | 11 ++++++-----
.../fineract/portfolio/calendar/service/CalendarUtils.java | 1 +
.../portfolio/loanaccount/domain/LoanTopupDetails.java | 2 +-
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml
index 11e79cd..bd68d88 100644
--- a/fineract-provider/config/checkstyle/checkstyle.xml
+++ b/fineract-provider/config/checkstyle/checkstyle.xml
@@ -94,6 +94,11 @@
<message key="name.invalidPattern"
value="Method type name ''{0}'' must match pattern ''{1}''."/>
</module>
+ <module name="EmptyLineSeparator">
+ <property name="allowNoEmptyLineBetweenFields" value="true"/>
+ <!-- No PACKAGE_DEF token, as we like our license header to be glue to "package" statement, to save 1 line screen space -->
+ <property name="tokens" value="IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
+ </module>
<module name="PackageName">
<property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]*)*$"/>
<message key="name.invalidPattern"
@@ -177,11 +182,7 @@
<module name="ModifierOrder"/>
<module name="RedundantModifier"/>
- <module name="EmptyLineSeparator">
- <property name="allowNoEmptyLineBetweenFields" value="true"/>
- < ! - - No PACKAGE_DEF token, as we like our license header to be glue to "package" statement, to save 1 line screen space - - >
- <property name="tokens" value="IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
- </module>
+
<module name="SeparatorWrap">
<property name="tokens" value="DOT"/>
<property name="option" value="nl"/>
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
index 42820e5..605b497 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
@@ -57,6 +57,7 @@ import org.slf4j.LoggerFactory;
public class CalendarUtils {
private final static Logger LOG = LoggerFactory.getLogger(CalendarUtils.class);
+
static {
System.setProperty("net.fortuna.ical4j.timezone.date.floating", "true");
}
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTopupDetails.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTopupDetails.java
index d3553df..36f05c5 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTopupDetails.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTopupDetails.java
@@ -43,7 +43,7 @@ public class LoanTopupDetails extends AbstractPersistableCustom {
@Column(name = "topup_amount", nullable = true)
private BigDecimal topupAmount;
- protected LoanTopupDetails() {};
+ protected LoanTopupDetails() {}
public LoanTopupDetails(final Loan loan, final Long loanIdToClose) {
this.loan = loan;