[GitHub] [incubator-livy] captainzmc commented on a change in pull request #238: [LIVY-689] Deliver stage process message to the end user using thriftserver

[GitBox <gi...@apache.org>]

captainzmc commented on a change in pull request #238: [LIVY-689] Deliver stage process message to the end user using thriftserver
URL: https://github.com/apache/incubator-livy/pull/238#discussion_r329485621
 
 

 ##########
 File path: rsc/src/main/java/org/apache/livy/rsc/RSCClient.java
 ##########
 @@ -413,6 +426,28 @@ private void handle(ChannelHandlerContext ctx, JobResult msg) {
       }
     }
 
+    private void handle(ChannelHandlerContext ctx, JobProcessMessage msg){
 
 Review comment:
   It feels better to use text descriptions. It is also easier to parse if we need to collect logs:
   
   Stage:0 Finished:8 Total:25; Running job progress: 32%

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services