You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/06/14 13:34:17 UTC
[GitHub] [fineract] logoutdhaval opened a new pull request, #2363: FINERACT-1641: Invalid Date of transaction after reversal correction
logoutdhaval opened a new pull request, #2363:
URL: https://github.com/apache/fineract/pull/2363
## Description
[FINERACT-1641](https://issues.apache.org/jira/browse/FINERACT-1641).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2363: FINERACT-1641: Invalid Date of transaction after reversal correction
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2363:
URL: https://github.com/apache/fineract/pull/2363#discussion_r897877900
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java:
##########
@@ -303,9 +304,11 @@ public static void updateTaxDetails(final Map<TaxComponent, BigDecimal> taxDetai
}
public static SavingsAccountTransaction copyTransaction(SavingsAccountTransaction accountTransaction) {
+ LocalDateTime date = DateUtils.getLocalDateTimeOfTenant();
+ Date createdDate = Date.from(date.atZone(ZoneId.systemDefault()).toInstant());
Review Comment:
Why all this instead of just doing a DateUtils.getLocalDate()? It's much simpler and gets the current date properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2363: FINERACT-1641: Invalid Date of transaction after reversal correction
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2363:
URL: https://github.com/apache/fineract/pull/2363#discussion_r897629070
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountTransaction.java:
##########
@@ -304,8 +304,8 @@ public static void updateTaxDetails(final Map<TaxComponent, BigDecimal> taxDetai
public static SavingsAccountTransaction copyTransaction(SavingsAccountTransaction accountTransaction) {
return new SavingsAccountTransaction(accountTransaction.savingsAccount, accountTransaction.office, accountTransaction.paymentDetail,
- accountTransaction.typeOf, accountTransaction.transactionLocalDate(), accountTransaction.createdDate,
- accountTransaction.amount, accountTransaction.reversed, accountTransaction.appUser, accountTransaction.isManualTransaction,
+ accountTransaction.typeOf, accountTransaction.transactionLocalDate(), new Date(), accountTransaction.amount,
Review Comment:
Rather should be `DateUtils#getLocalDateOfTenant` IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj closed pull request #2363: FINERACT-1641: Invalid Date of transaction after reversal correction
Posted by GitBox <gi...@apache.org>.
fynmanoj closed pull request #2363: FINERACT-1641: Invalid Date of transaction after reversal correction
URL: https://github.com/apache/fineract/pull/2363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2363: FINERACT-1641: Invalid Date of transaction after reversal correction
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2363:
URL: https://github.com/apache/fineract/pull/2363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org