You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "js8544 (via GitHub)" <gi...@apache.org> on 2023/02/13 09:48:04 UTC
[GitHub] [arrow] js8544 opened a new pull request, #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
js8544 opened a new pull request, #34159:
URL: https://github.com/apache/arrow/pull/34159
Using OpenSSL causes various issues like https://github.com/apache/arrow/pull/33808#issuecomment-1408247269 and https://github.com/apache/arrow/issues/34111. We should try to use aws-lc for libcrypto and libssl. We need to hide them inside s2n-tls to avoid name conflicts with OpenSSL used by other libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427766681
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427847470
Revision: 648f512323b86e405d4d2ec6764992ea32f9e001
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6197616fec](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6197616fec)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4163331626/jobs/7203595627)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428405474
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105007159
##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -135,6 +136,7 @@ archery linking check-dependencies \
--allow libncurses \
--allow libobjc \
--allow libplasma_java \
+ --allow libprotobuf \
Review Comment:
We should not allow `libprotobuf` because `libprotobuf` isn't a system library.
Which library requires `libprotobuf`?
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4779,9 +4805,22 @@ macro(build_awssdk)
aws-c-event-stream
aws-c-io
aws-c-cal
- s2n-tls
aws-checksums
aws-c-common)
+
+ # aws-lc needs to be installed on a separate folder to hide from unintended use
+ set(AWS_LC_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/aws_lc_ep-install")
+ set(AWS_LC_INCLUDE_DIR "${AWS_LC_PREFIX}/include")
+
+ if(UNIX AND NOT APPLE) # aws-lc and s2n-tls only needed on linux
+ file(MAKE_DIRECTORY ${AWS_LC_INCLUDE_DIR})
+ list(APPEND
+ _AWSSDK_LIBS
+ s2n-tls
+ crypto
+ ssl)
Review Comment:
Can we use `aws-lc` instead of `crypto` and `ssl`?
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4727,20 +4735,38 @@ macro(build_awssdk)
set(AWSSDK_BUILD_TYPE release)
endif()
+ # provide hint for AWS SDK to link with the already located openssl
+ get_filename_component(OPENSSL_ROOT_HINT "${OPENSSL_INCLUDE_DIR}" DIRECTORY)
+ if(APPLE AND NOT OPENSSL_ROOT_HINT)
+ find_program(BREW brew)
+ if(BREW)
+ execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
+ OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL11_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL11_BREW_PREFIX})
+ else()
+ execute_process(COMMAND ${BREW} --prefix "openssl"
+ OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL_BREW_PREFIX})
+ endif()
+ endif()
+ endif()
+ endif()
Review Comment:
Do we need this?
`OPENSSL_INCLUDE_DIR` must be set by `find_package(OpenSSL)`.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4827,37 +4881,41 @@ macro(build_awssdk)
DEPENDS aws_c_common_ep)
add_dependencies(AWS::aws-checksums aws_checksums_ep)
- set(S2N_TLS_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
- if(APPLE AND NOT OPENSSL_ROOT_DIR)
- find_program(BREW brew)
- if(BREW)
- execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
- OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
- OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL11_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL11_BREW_PREFIX})
- else()
- execute_process(COMMAND ${BREW} --prefix "openssl"
- OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
- OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL_BREW_PREFIX})
- endif()
- endif()
- endif()
- endif()
- if(OPENSSL_ROOT_DIR)
- # For Findcrypto.cmake in s2n-tls.
- list(APPEND S2N_TLS_CMAKE_ARGS -DCMAKE_PREFIX_PATH=${OPENSSL_ROOT_DIR})
+ if(UNIX AND NOT APPLE) # aws-lc and s2n-tls only needed on linux
+ set(AWS_LC_C_FLAGS ${EP_C_FLAGS})
+ list(APPEND AWS_LC_C_FLAGS "-Wno-error=overlength-strings")
+
+ set(AWS_LC_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ list(APPEND AWS_LC_CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${AWS_LC_PREFIX}
+ -DCMAKE_C_FLAGS=${AWS_LC_C_FLAGS})
+ externalproject_add(aws_lc_ep
+ ${EP_COMMON_OPTIONS}
+ URL ${AWS_LC_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_AWS_LC_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${AWS_LC_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${SSL_STATIC_LIBRARY} ${CRYPTO_STATIC_LIBRARY})
+ add_dependencies(AWS::crypto aws_lc_ep)
+ add_dependencies(AWS::ssl aws_lc_ep)
+
+ set(S2N_TLS_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ list(APPEND
+ S2N_TLS_CMAKE_ARGS
+ -DS2N_INTERN_LIBCRYPTO=ON # internalize libcrypto to avoid name conflict with openssl
+ -DCMAKE_PREFIX_PATH=${AWS_LC_PREFIX}) # path to find crypto provided by aws-lc
+
+ externalproject_add(s2n_tls_ep
+ ${EP_COMMON_OPTIONS}
+ URL ${S2N_TLS_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${S2N_TLS_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${S2N_TLS_STATIC_LIBRARY}
+ DEPENDS aws_lc_ep)
+ add_dependencies(AWS::s2n-tls s2n_tls_ep)
endif()
- externalproject_add(s2n_tls_ep
- ${EP_COMMON_OPTIONS}
- URL ${S2N_TLS_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM}"
- CMAKE_ARGS ${S2N_TLS_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${S2N_TLS_STATIC_LIBRARY})
- add_dependencies(AWS::s2n-tls s2n_tls_ep)
+ set(AWS_C_CAL_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ # Because aws-c-cal doesn't provide ability to hide libcrypto, we have to always use openssl
+ list(APPEND AWS_C_CAL_CMAKE_ARGS -DUSE_OPENSSL=ON)
Review Comment:
Could you use this in `externalproject_add(aws_c_cal_ep)`?
Or is it needless?
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4985,6 +5047,14 @@ macro(build_awssdk)
set_property(TARGET CURL::libcurl
APPEND
PROPERTY INTERFACE_LINK_LIBRARIES OpenSSL::SSL)
Review Comment:
This is not related to this pull rquest but we should do this in `find_curl()`.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4796,6 +4835,11 @@ macro(build_awssdk)
"${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}s2n${CMAKE_STATIC_LIBRARY_SUFFIX}"
)
endif()
+ if(${_AWSSDK_LIB} STREQUAL "crypto" OR ${_AWSSDK_LIB} STREQUAL "ssl")
Review Comment:
```suggestion
elseif(${_AWSSDK_LIB} STREQUAL "crypto" OR ${_AWSSDK_LIB} STREQUAL "ssl")
```
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4827,37 +4881,41 @@ macro(build_awssdk)
DEPENDS aws_c_common_ep)
add_dependencies(AWS::aws-checksums aws_checksums_ep)
- set(S2N_TLS_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
- if(APPLE AND NOT OPENSSL_ROOT_DIR)
- find_program(BREW brew)
- if(BREW)
- execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
- OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
- OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL11_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL11_BREW_PREFIX})
- else()
- execute_process(COMMAND ${BREW} --prefix "openssl"
- OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
- OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL_BREW_PREFIX})
- endif()
- endif()
- endif()
- endif()
- if(OPENSSL_ROOT_DIR)
- # For Findcrypto.cmake in s2n-tls.
- list(APPEND S2N_TLS_CMAKE_ARGS -DCMAKE_PREFIX_PATH=${OPENSSL_ROOT_DIR})
+ if(UNIX AND NOT APPLE) # aws-lc and s2n-tls only needed on linux
Review Comment:
```suggestion
if("s2n-tls" IN_LIST _AWSSDK_LIBS)
```
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4867,13 +4925,17 @@ macro(build_awssdk)
DEPENDS aws_c_common_ep)
add_dependencies(AWS::aws-c-cal aws_c_cal_ep)
+ set(AWS_C_IO_DEPENDS aws_c_common_ep aws_c_cal_ep)
+ if(UNIX AND NOT APPLE)
Review Comment:
```suggestion
if(TARGET s2n_tls_ep)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428151983
Revision: ce7bdbb6f60b3318e9f14b8c4a95ce70e004ea29
Submitted crossbow builds: [ursacomputing/crossbow @ actions-55f6f598a9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-55f6f598a9)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4165091508/jobs/7207612643)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430826683
@github-actions crossbow submit -g cpp -g r java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429085452
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105265178
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4796,6 +4835,11 @@ macro(build_awssdk)
"${AWSSDK_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}s2n${CMAKE_STATIC_LIBRARY_SUFFIX}"
)
endif()
+ if(${_AWSSDK_LIB} STREQUAL "crypto" OR ${_AWSSDK_LIB} STREQUAL "ssl")
Review Comment:
changed to aws-lc
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4779,9 +4805,22 @@ macro(build_awssdk)
aws-c-event-stream
aws-c-io
aws-c-cal
- s2n-tls
aws-checksums
aws-c-common)
+
+ # aws-lc needs to be installed on a separate folder to hide from unintended use
+ set(AWS_LC_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/aws_lc_ep-install")
+ set(AWS_LC_INCLUDE_DIR "${AWS_LC_PREFIX}/include")
+
+ if(UNIX AND NOT APPLE) # aws-lc and s2n-tls only needed on linux
+ file(MAKE_DIRECTORY ${AWS_LC_INCLUDE_DIR})
+ list(APPEND
+ _AWSSDK_LIBS
+ s2n-tls
+ crypto
+ ssl)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1106603649
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4727,20 +4735,38 @@ macro(build_awssdk)
set(AWSSDK_BUILD_TYPE release)
endif()
+ # provide hint for AWS SDK to link with the already located openssl
+ get_filename_component(OPENSSL_ROOT_HINT "${OPENSSL_INCLUDE_DIR}" DIRECTORY)
+ if(APPLE AND NOT OPENSSL_ROOT_HINT)
+ find_program(BREW brew)
+ if(BREW)
+ execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
+ OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL11_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL11_BREW_PREFIX})
+ else()
+ execute_process(COMMAND ${BREW} --prefix "openssl"
+ OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL_BREW_PREFIX})
+ endif()
+ endif()
+ endif()
+ endif()
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1431069952
> Sorry. Can we try this?
>
> ```diff
> diff --git a/ci/scripts/java_jni_macos_build.sh b/ci/scripts/java_jni_macos_build.sh
> index 391d05642..37bbe1283 100755
> --- a/ci/scripts/java_jni_macos_build.sh
> +++ b/ci/scripts/java_jni_macos_build.sh
> @@ -109,6 +109,7 @@ fi
> popd
>
>
> +export JAVA_JNI_CMAKE_ARGS="-DProtobuf_ROOT=${build_dir}/cpp/protobuf_ep-install"
> ${arrow_dir}/ci/scripts/java_jni_build.sh \
> ${arrow_dir} \
> ${install_dir} \
> ```
It works. Thanks for suggesting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429564307
Revision: 7ddc9097ad5f484ca4988565854b18cf5579b91a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2d1c4bfd52](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2d1c4bfd52)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4173260638/jobs/7225377893)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1106396075
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4727,20 +4735,38 @@ macro(build_awssdk)
set(AWSSDK_BUILD_TYPE release)
endif()
+ # provide hint for AWS SDK to link with the already located openssl
+ get_filename_component(OPENSSL_ROOT_HINT "${OPENSSL_INCLUDE_DIR}" DIRECTORY)
+ if(APPLE AND NOT OPENSSL_ROOT_HINT)
+ find_program(BREW brew)
+ if(BREW)
+ execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
+ OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL11_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL11_BREW_PREFIX})
+ else()
+ execute_process(COMMAND ${BREW} --prefix "openssl"
+ OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL_BREW_PREFIX})
+ endif()
+ endif()
+ endif()
+ endif()
Review Comment:
It was needed but I should have reused `OPENSSL_ROOT_HINT`. I didn't notice it. Sorry.
Could you try removing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1432228907
Benchmark runs are scheduled for baseline = b955da0597d2899f58cfc7b2e842075ecf900b0f and contender = 798b417ec342051f3ff30b9953dcb1f1b71dc9e8. 798b417ec342051f3ff30b9953dcb1f1b71dc9e8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/add5b85d3d6444fdb076b555176e1ae5...7627303b2c8a482c836491a4b27a861c/)
[Failed :arrow_down:0.18% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3330d20fe4544963b6349cb13f1af61b...9f1f1b50e8b44fde8fc8893bfb295101/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eb78cfd44ba942e5807f903125d689db...f8543db9d7d1402a90f8b65ceda6c948/)
[Finished :arrow_down:0.22% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e086eb1ddd9a464f96bf1208eec4512a...1a155dd4c59949889aa2b1854ef28a13/)
Buildkite builds:
[Finished] [`798b417e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2378)
[Finished] [`798b417e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2408)
[Finished] [`798b417e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2376)
[Finished] [`798b417e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2400)
[Finished] [`b955da05` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2377)
[Failed] [`b955da05` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2407)
[Finished] [`b955da05` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2375)
[Finished] [`b955da05` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2399)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430821186
CI failures are unrelated. I think this is ready to to merged. cc @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428041609
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428309459
Revision: 3a80394442cdbb2bf33afd7a674f50ca9e0e6267
Submitted crossbow builds: [ursacomputing/crossbow @ actions-dba11d7a8f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-dba11d7a8f)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-dba11d7a8f-azure-conda-linux-aarch64-cpu-r41)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/tree/actions-dba11d7a8f-azure-conda-linux-aarch64-cpu-r42)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11306380780)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11306393948)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11306411886)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11306356399)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11306335517)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11306386615)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11306400743)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4165869850/jobs/7209464585)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4165881805/jobs/7209486953)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4165877546/jobs/7209489928)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4165863268/jobs/7209445676)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4165867140/jobs/7209454826)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4165880271/jobs/7209482648)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11306333529)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4165874999/jobs/7209470799)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4165878209/jobs/7209477207)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4165864440/jobs/7209448912)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4165894514/jobs/7209517829)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4165868656/jobs/7209457953)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4165874347/jobs/7209469807)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11306392822)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4165891118/jobs/7209508593)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11306372681)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4165888430/jobs/7209502540)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4165879783/jobs/7209480930)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4165875925/jobs/7209472855)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4165882612/jobs/7209488577)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4165893307/jobs/7209514084)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4165890420/jobs/7209507174)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4165876711/jobs/7209474091)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11306345261)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4165886905/jobs/7209498853)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4165884124/jobs/7209491706)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11306358094)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11306415227)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4165886528/jobs/7209497236)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11306413707)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11306404672)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11306379153)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11306330939)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11306399362)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11306349886)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11306371068)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4165865964/jobs/7209452444)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4165880670/jobs/7209484463)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4165894119/jobs/7209516703)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4165872632/jobs/7209466107)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4165863645/jobs/7209446645)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11306348263)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4165871942/jobs/7209464456)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4165862888/jobs/7209444517)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4165889496/jobs/7209505214)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4165871587/jobs/7209463653)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4165884726/jobs/7209493270)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429677813
CMake somehow cannot find brew installed libprotobuf even if I supply Protobuf_ROOT. [The error log](https://pipelines.actions.githubusercontent.com/serviceHosts/36b0b1a0-9453-4f79-b171-2b3905790445/_apis/pipelines/1/runs/134813/signedlogcontent/7?urlExpires=2023-02-14T12%3A24%3A29.0803195Z&urlSigningMethod=HMACV1&urlSignature=Vq8uKR48GIOK0zVJXSsnz27XHch8h5UveMA3dqRsXds%3D) gives:
```
2023-02-14T11:31:53.4607330Z -- Could NOT find Protobuf (missing: Protobuf_LIBRARIES) (found suitable version "3.21.12", minimum required is "2.6.1")
2023-02-14T11:31:53.4610530Z -- Building Protocol Buffers from source
```
I checked the [last successful java-jars build](https://github.com/ursacomputing/crossbow/actions/runs/4122242694/jobs/7118788009
), it does find brew's protobuf correctly:
```
Found Protobuf: /usr/local/lib/libprotobuf.a (found suitable version "3.21.12", minimum required is "2.6.1")
```
Everything else is working except for this protobuf issue which is actually unrelated to this pr. cc @kou Could you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427636983
* Closes: #34157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427638724
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427851001
Revision: 648f512323b86e405d4d2ec6764992ea32f9e001
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b821c79bb2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b821c79bb2)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-b821c79bb2-azure-conda-linux-aarch64-cpu-r41)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11298573846)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11298586591)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11298608657)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11298598758)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11298614791)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11298566741)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11298590992)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11298581589)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4163336374/jobs/7203606372)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4163339752/jobs/7203613686)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4163348192/jobs/7203647149)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4163353536/jobs/7203644859)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4163346231/jobs/7203628424)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4163345696/jobs/7203627327)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11298623025)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4163349948/jobs/7203636696)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4163337151/jobs/7203607817)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4163354117/jobs/7203645989)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4163333080/jobs/7203598321)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4163342682/jobs/7203620148)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4163350392/jobs/7203637646)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11298636016)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4163335961/jobs/7203605073)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11298594774)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4163347621/jobs/7203631408)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4163354775/jobs/7203647377)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4163343149/jobs/7203621549)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4163340431/jobs/7203615185)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4163344355/jobs/7203624184)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4163352099/jobs/7203641937)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4163336810/jobs/7203607099)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11298620286)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4163352675/jobs/7203643642)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4163355723/jobs/7203649403)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11298616441)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11298621647)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4163331712/jobs/7203595289)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11298604489)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11298640159)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11298637262)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11298585212)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11298569990)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11298572386)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11298609744)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4163343935/jobs/7203623213)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4163341801/jobs/7203618743)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4163338408/jobs/7203610625)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4163335609/jobs/7203604165)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4163344823/jobs/7203625287)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11298592686)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4163356813/jobs/7203652275)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4163337995/jobs/7203609710)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4163332143/jobs/7203596184)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4163355203/jobs/7203648292)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4163353070/jobs/7203643801)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1432215666
@js8544 It seems that we need more work for manylinux wheels. Could you open a new issue for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105506741
##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -135,6 +136,7 @@ archery linking check-dependencies \
--allow libncurses \
--allow libobjc \
--allow libplasma_java \
+ --allow libprotobuf \
Review Comment:
From what I can tell, [This line](https://github.com/apache/arrow/blob/master/java/gandiva/CMakeLists.txt#L41) gives this:
```
2023-02-14T08:45:58.6020450Z -- Found Protobuf: /usr/local/lib/libprotobuf.dylib (found version "3.21.12")
```
in [this log](https://pipelines.actions.githubusercontent.com/serviceHosts/36b0b1a0-9453-4f79-b171-2b3905790445/_apis/pipelines/1/runs/134770/signedlogcontent/7?urlExpires=2023-02-14T08%3A59%3A03.1286297Z&urlSigningMethod=HMACV1&urlSignature=LtsaqA2TGb81lINJYHSn9P7YcBMFO89zYknLi%2Bik4LY%3D). Is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430862825
Revision: f44c1bfaa32386e8a3ababfb1910e4954874f366
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7b13f07b9d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7b13f07b9d)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-7b13f07b9d-azure-conda-linux-aarch64-cpu-r41)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/tree/actions-7b13f07b9d-azure-conda-linux-aarch64-cpu-r42)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11351173841)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11351172203)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11351208507)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11351189173)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11351213364)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11351172817)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11351204945)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4181468478/jobs/7243443037)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4181460493/jobs/7243426612)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4181466976/jobs/7243439810)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4181462871/jobs/7243438609)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181456286/jobs/7243417879)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4181457042/jobs/7243419666)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181456536/jobs/7243418470)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11351183370)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181464590/jobs/7243434787)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4181462094/jobs/7243429785)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4181461727/jobs/7243429151)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4181473767/jobs/7243453845)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4181469855/jobs/7243445758)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181471710/jobs/7243449398)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11351204211)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4181461053/jobs/7243427866)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11351176874)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4181463950/jobs/7243433389)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4181467989/jobs/7243441513)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4181466516/jobs/7243438903)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4181463641/jobs/7243432761)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4181465063/jobs/7243435830)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4181459777/jobs/7243425057)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4181459422/jobs/7243424296)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11351169851)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4181460788/jobs/7243427585)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4181467680/jobs/7243440846)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11351191611)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11351195131)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4181463306/jobs/7243432038)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11351180406)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11351166145)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11351192454)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11351201356)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11351199197)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11351211395)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11351170867)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4181455746/jobs/7243416598)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4181469125/jobs/7243444801)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181472549/jobs/7243451300)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4181472794/jobs/7243451873)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4181464237/jobs/7243433993)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11351210703)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181468204/jobs/7243442099)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4181472007/jobs/7243450008)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4181471350/jobs/7243448740)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4181465405/jobs/7243436548)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181460090/jobs/7243425618)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427766349
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428052832
Revision: 09bb8b5e6388643e13d2d5b1d53597fd57023eab
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2e759d9851](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2e759d9851)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4164572857/jobs/7206381855)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428261267
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427638490
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430392676
Ah, this is caused by https://github.com/Homebrew/homebrew-core/pull/122277 .
Homebrew stopped providing `libprotobuf.a`.
We need to prepare `libprotobuf.a` for us. But it is not related to this pull request. Could you open a new issue for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427844195
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105259181
##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -135,6 +136,7 @@ archery linking check-dependencies \
--allow libncurses \
--allow libobjc \
--allow libplasma_java \
+ --allow libprotobuf \
Review Comment:
https://github.com/ursacomputing/crossbow/actions/runs/4165692619/jobs/7209047999 From the error log:
`2023-02-13T17:54:24.6436120Z Error: Unexpected shared dependency found in libgandiva_jni.dylib: libprotobuf`
(You need to view raw log to see this. The log size is too large.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427644730
Revision: 8b547a8ba8ec811cb9711b4a8608171d54448993
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ae2876b60b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ae2876b60b)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11295171245)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11295207457)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11295210405)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11295172383)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11295187457)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11295220978)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11295203148)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11295197433)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11295229362)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4162187009/jobs/7201049980)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4162173095/jobs/7201017788)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4162179211/jobs/7201042100)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162190556/jobs/7201058282)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4162170963/jobs/7201012716)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162185495/jobs/7201045767)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11295206398)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162182852/jobs/7201039308)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4162184374/jobs/7201043049)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4162172695/jobs/7201016834)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4162181715/jobs/7201036680)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4162188083/jobs/7201052163)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162188688/jobs/7201053696)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11295193107)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4162176612/jobs/7201025580)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11295216144)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4162174293/jobs/7201020526)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4162187695/jobs/7201051195)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4162184683/jobs/7201044140)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4162169066/jobs/7201008226)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4162180453/jobs/7201034057)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4162178091/jobs/7201028920)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4162170567/jobs/7201012020)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11295178405)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4162180018/jobs/7201033717)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4162187356/jobs/7201050363)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11295188702)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11295169988)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4162171822/jobs/7201014924)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11295185556)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11295183010)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11295218542)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11295226841)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11295228823)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11295231370)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11295199684)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4162177015/jobs/7201026493)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4162190164/jobs/7201057866)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162175205/jobs/7201022580)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4162186250/jobs/7201047688)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4162171398/jobs/7201013872)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11295211215)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162178409/jobs/7201029496)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4162189530/jobs/7201055913)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4162183948/jobs/7201041895)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4162181299/jobs/7201035889)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162173520/jobs/7201018712)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428071911
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429087542
Revision: dc8765de7406a7276d164aa8556a53afea6adc9c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-03de1fb312](https://github.com/ursacomputing/crossbow/branches/all?query=actions-03de1fb312)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4170372094/jobs/7219273063)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34159:
URL: https://github.com/apache/arrow/pull/34159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1106406288
##########
java/gandiva/CMakeLists.txt:
##########
@@ -38,6 +38,7 @@ set(GANDIVA_PROTO_DIR ${CMAKE_CURRENT_SOURCE_DIR}/proto)
get_filename_component(GANDIVA_PROTO_FILE_ABSOLUTE ${GANDIVA_PROTO_DIR}/Types.proto
ABSOLUTE)
+set(Protobuf_USE_STATIC_LIBS ON)
Review Comment:
Could you specify this in build script (`ci/scripts/java_jni_build.sh`)?
Some users may want to use `libprotobuf.so`.
##########
java/gandiva/CMakeLists.txt:
##########
@@ -38,6 +38,7 @@ set(GANDIVA_PROTO_DIR ${CMAKE_CURRENT_SOURCE_DIR}/proto)
get_filename_component(GANDIVA_PROTO_FILE_ABSOLUTE ${GANDIVA_PROTO_DIR}/Types.proto
ABSOLUTE)
+set(Protobuf_USE_STATIC_LIBS ON)
find_package(Protobuf REQUIRED)
if(MSVC)
Review Comment:
It's not related to this pull request but could you remove this `if(MSVC)`? It's not needed with recent CMake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430857404
@github-actions crossbow submit -g cpp -g r java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428075963
Revision: a69234ceeb6a02237309caf238899017ef95dad3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8ba64f2683](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8ba64f2683)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4164705049/jobs/7206697718)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428408948
Revision: 06db0bcaf9dc3368dc28af97b3a7daaafa2ff5a7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-074f03da6a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-074f03da6a)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4166357309/jobs/7210596903)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428041193
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428433036
Revision: 06db0bcaf9dc3368dc28af97b3a7daaafa2ff5a7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ac12605959](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ac12605959)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-ac12605959-azure-conda-linux-aarch64-cpu-r41)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11308229711)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11308227135)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11308223701)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11308221494)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11308265048)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11308225948)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11308234695)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11308277543)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4166499680/jobs/7210913218)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4166486084/jobs/7210882428)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4166477474/jobs/7210875588)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4166481458/jobs/7210872068)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4166484125/jobs/7210878052)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4166500586/jobs/7210914655)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11308286884)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4166497337/jobs/7210907773)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4166491864/jobs/7210895071)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4166491500/jobs/7210894175)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4166485111/jobs/7210880266)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4166496378/jobs/7210905646)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4166504050/jobs/7210921720)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11308270231)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4166486506/jobs/7210883447)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11308263984)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4166482745/jobs/7210875014)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4166500160/jobs/7210913713)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4166488890/jobs/7210889168)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4166494936/jobs/7210902375)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4166477920/jobs/7210864450)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4166502507/jobs/7210918648)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4166503106/jobs/7210919763)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11308253436)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4166492823/jobs/7210897865)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4166491040/jobs/7210893177)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11308255246)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11308230872)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4166486968/jobs/7210884337)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11308222565)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11308220418)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11308274918)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11308245915)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11308280038)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11308247321)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11308271333)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4166483230/jobs/7210875944)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4166484617/jobs/7210879714)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4166494107/jobs/7210900399)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4166494478/jobs/7210901300)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4166503557/jobs/7210920597)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11308240475)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4166501989/jobs/7210917570)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4166501413/jobs/7210916443)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4166499224/jobs/7210911867)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4166492373/jobs/7210896190)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4166498215/jobs/7210909641)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429262884
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105263440
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4827,37 +4881,41 @@ macro(build_awssdk)
DEPENDS aws_c_common_ep)
add_dependencies(AWS::aws-checksums aws_checksums_ep)
- set(S2N_TLS_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
- if(APPLE AND NOT OPENSSL_ROOT_DIR)
- find_program(BREW brew)
- if(BREW)
- execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
- OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
- OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL11_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL11_BREW_PREFIX})
- else()
- execute_process(COMMAND ${BREW} --prefix "openssl"
- OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
- OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL_BREW_PREFIX})
- endif()
- endif()
- endif()
- endif()
- if(OPENSSL_ROOT_DIR)
- # For Findcrypto.cmake in s2n-tls.
- list(APPEND S2N_TLS_CMAKE_ARGS -DCMAKE_PREFIX_PATH=${OPENSSL_ROOT_DIR})
+ if(UNIX AND NOT APPLE) # aws-lc and s2n-tls only needed on linux
+ set(AWS_LC_C_FLAGS ${EP_C_FLAGS})
+ list(APPEND AWS_LC_C_FLAGS "-Wno-error=overlength-strings")
+
+ set(AWS_LC_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ list(APPEND AWS_LC_CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${AWS_LC_PREFIX}
+ -DCMAKE_C_FLAGS=${AWS_LC_C_FLAGS})
+ externalproject_add(aws_lc_ep
+ ${EP_COMMON_OPTIONS}
+ URL ${AWS_LC_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_AWS_LC_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${AWS_LC_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${SSL_STATIC_LIBRARY} ${CRYPTO_STATIC_LIBRARY})
+ add_dependencies(AWS::crypto aws_lc_ep)
+ add_dependencies(AWS::ssl aws_lc_ep)
+
+ set(S2N_TLS_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ list(APPEND
+ S2N_TLS_CMAKE_ARGS
+ -DS2N_INTERN_LIBCRYPTO=ON # internalize libcrypto to avoid name conflict with openssl
+ -DCMAKE_PREFIX_PATH=${AWS_LC_PREFIX}) # path to find crypto provided by aws-lc
+
+ externalproject_add(s2n_tls_ep
+ ${EP_COMMON_OPTIONS}
+ URL ${S2N_TLS_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${S2N_TLS_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${S2N_TLS_STATIC_LIBRARY}
+ DEPENDS aws_lc_ep)
+ add_dependencies(AWS::s2n-tls s2n_tls_ep)
endif()
- externalproject_add(s2n_tls_ep
- ${EP_COMMON_OPTIONS}
- URL ${S2N_TLS_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM}"
- CMAKE_ARGS ${S2N_TLS_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${S2N_TLS_STATIC_LIBRARY})
- add_dependencies(AWS::s2n-tls s2n_tls_ep)
+ set(AWS_C_CAL_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ # Because aws-c-cal doesn't provide ability to hide libcrypto, we have to always use openssl
+ list(APPEND AWS_C_CAL_CMAKE_ARGS -DUSE_OPENSSL=ON)
Review Comment:
Seems like it's not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429395403
Revision: f8e6b41d688ee635cc773b3057b66727902ae75c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b4b07db048](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b4b07db048)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4172301738/jobs/7223232433)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430895098
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428033623
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428042560
Revision: 561a1471df3f7fc76703d8c54ebff63a5fbe4212
Submitted crossbow builds: [ursacomputing/crossbow @ actions-eb6d150c35](https://github.com/ursacomputing/crossbow/branches/all?query=actions-eb6d150c35)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-eb6d150c35-azure-conda-linux-aarch64-cpu-r41)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11301984155)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11301979289)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11301989602)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-eb6d150c35-azure-conda-osx-arm64-cpu-r41)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11302022356)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11302018723)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11302008500)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11302014602)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4164492461/jobs/7206200490)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4164490896/jobs/7206196324)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4164512039/jobs/7206245878)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164513085/jobs/7206248084)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4164499586/jobs/7206216582)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164489851/jobs/7206194042)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11302031064)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164498098/jobs/7206212823)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4164499973/jobs/7206217748)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4164510968/jobs/7206243361)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4164486197/jobs/7206186349)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4164484058/jobs/7206181024)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164498601/jobs/7206214225)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11301995127)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4164510502/jobs/7206242325)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11302021387)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4164509383/jobs/7206239980)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4164485728/jobs/7206184729)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4164486644/jobs/7206187472)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4164508372/jobs/7206237611)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4164485075/jobs/7206183455)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4164496312/jobs/7206209277)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4164503822/jobs/7206227192)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11302001611)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4164507007/jobs/7206235404)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4164503134/jobs/7206225573)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11302059048)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11302052171)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4164501986/jobs/7206223150)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11302048515)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11302003883)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11302041597)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11301980971)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11302035471)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11301992013)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11301982371)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4164487149/jobs/7206188441)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4164506564/jobs/7206233867)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164508920/jobs/7206238849)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4164505585/jobs/7206230744)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4164490354/jobs/7206195543)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11302006906)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164484527/jobs/7206182739)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4164502554/jobs/7206224207)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4164493562/jobs/7206202555)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4164512534/jobs/7206246933)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164483465/jobs/7206179921)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428183295
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428265649
Revision: 3a80394442cdbb2bf33afd7a674f50ca9e0e6267
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7800863a35](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7800863a35)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4165692619/jobs/7209048189)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428293111
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430897386
Revision: 89c547c1e26a4c42c7ec291ee154760146275647
Submitted crossbow builds: [ursacomputing/crossbow @ actions-4bf574a4e3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4bf574a4e3)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4181723496/jobs/7243959852)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1432012081
Revision: 89c547c1e26a4c42c7ec291ee154760146275647
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5407ab76c8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5407ab76c8)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187994235/jobs/7258559190)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187998892/jobs/7258570049)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187999305/jobs/7258570811)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187997069/jobs/7258566000)|
|wheel-macos-mojave-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187999717/jobs/7258571605)|
|wheel-macos-mojave-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187995240/jobs/7258561810)|
|wheel-macos-mojave-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187996033/jobs/7258563562)|
|wheel-macos-mojave-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4188001389/jobs/7258575424)|
|wheel-macos-mojave-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187993466/jobs/7258557474)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4188001084/jobs/7258574811)|
|wheel-manylinux2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/runs/11371072862)|
|wheel-manylinux2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187994550/jobs/7258560020)|
|wheel-manylinux2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/runs/11371080110)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187997839/jobs/7258567769)|
|wheel-manylinux2014-cp37-arm64|[](https://github.com/ursacomputing/crossbow/runs/11371070660)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187994912/jobs/7258561014)|
|wheel-manylinux2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/runs/11371077866)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4188002103/jobs/7258577398)|
|wheel-manylinux2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/runs/11371068693)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187998600/jobs/7258569308)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187995683/jobs/7258562770)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187996374/jobs/7258564302)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4187993861/jobs/7258558330)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4188000410/jobs/7258573014)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105519345
##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -135,6 +136,7 @@ archery linking check-dependencies \
--allow libncurses \
--allow libobjc \
--allow libplasma_java \
+ --allow libprotobuf \
Review Comment:
I've changed Java Gandiva to use static protobuf lib. Let's see if it solves the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429391450
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427641634
Revision: 8b547a8ba8ec811cb9711b4a8608171d54448993
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2ee5337912](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2ee5337912)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4162171834/jobs/7201015526)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428037992
Revision: 561a1471df3f7fc76703d8c54ebff63a5fbe4212
Submitted crossbow builds: [ursacomputing/crossbow @ actions-301e77f082](https://github.com/ursacomputing/crossbow/branches/all?query=actions-301e77f082)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4164484019/jobs/7206181745)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428148300
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428424869
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105267460
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4985,6 +5047,14 @@ macro(build_awssdk)
set_property(TARGET CURL::libcurl
APPEND
PROPERTY INTERFACE_LINK_LIBRARIES OpenSSL::SSL)
Review Comment:
Moved to find_curl
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4827,37 +4881,41 @@ macro(build_awssdk)
DEPENDS aws_c_common_ep)
add_dependencies(AWS::aws-checksums aws_checksums_ep)
- set(S2N_TLS_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
- if(APPLE AND NOT OPENSSL_ROOT_DIR)
- find_program(BREW brew)
- if(BREW)
- execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
- OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
- OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL11_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL11_BREW_PREFIX})
- else()
- execute_process(COMMAND ${BREW} --prefix "openssl"
- OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
- OUTPUT_STRIP_TRAILING_WHITESPACE)
- if(OPENSSL_BREW_PREFIX)
- set(OPENSSL_ROOT_DIR ${OPENSSL_BREW_PREFIX})
- endif()
- endif()
- endif()
- endif()
- if(OPENSSL_ROOT_DIR)
- # For Findcrypto.cmake in s2n-tls.
- list(APPEND S2N_TLS_CMAKE_ARGS -DCMAKE_PREFIX_PATH=${OPENSSL_ROOT_DIR})
+ if(UNIX AND NOT APPLE) # aws-lc and s2n-tls only needed on linux
+ set(AWS_LC_C_FLAGS ${EP_C_FLAGS})
+ list(APPEND AWS_LC_C_FLAGS "-Wno-error=overlength-strings")
+
+ set(AWS_LC_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ list(APPEND AWS_LC_CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${AWS_LC_PREFIX}
+ -DCMAKE_C_FLAGS=${AWS_LC_C_FLAGS})
+ externalproject_add(aws_lc_ep
+ ${EP_COMMON_OPTIONS}
+ URL ${AWS_LC_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_AWS_LC_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${AWS_LC_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${SSL_STATIC_LIBRARY} ${CRYPTO_STATIC_LIBRARY})
+ add_dependencies(AWS::crypto aws_lc_ep)
+ add_dependencies(AWS::ssl aws_lc_ep)
+
+ set(S2N_TLS_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ list(APPEND
+ S2N_TLS_CMAKE_ARGS
+ -DS2N_INTERN_LIBCRYPTO=ON # internalize libcrypto to avoid name conflict with openssl
+ -DCMAKE_PREFIX_PATH=${AWS_LC_PREFIX}) # path to find crypto provided by aws-lc
+
+ externalproject_add(s2n_tls_ep
+ ${EP_COMMON_OPTIONS}
+ URL ${S2N_TLS_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${S2N_TLS_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${S2N_TLS_STATIC_LIBRARY}
+ DEPENDS aws_lc_ep)
+ add_dependencies(AWS::s2n-tls s2n_tls_ep)
endif()
- externalproject_add(s2n_tls_ep
- ${EP_COMMON_OPTIONS}
- URL ${S2N_TLS_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM}"
- CMAKE_ARGS ${S2N_TLS_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${S2N_TLS_STATIC_LIBRARY})
- add_dependencies(AWS::s2n-tls s2n_tls_ep)
+ set(AWS_C_CAL_CMAKE_ARGS ${AWSSDK_COMMON_CMAKE_ARGS})
+ # Because aws-c-cal doesn't provide ability to hide libcrypto, we have to always use openssl
+ list(APPEND AWS_C_CAL_CMAKE_ARGS -DUSE_OPENSSL=ON)
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105265697
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4727,20 +4735,38 @@ macro(build_awssdk)
set(AWSSDK_BUILD_TYPE release)
endif()
+ # provide hint for AWS SDK to link with the already located openssl
+ get_filename_component(OPENSSL_ROOT_HINT "${OPENSSL_INCLUDE_DIR}" DIRECTORY)
+ if(APPLE AND NOT OPENSSL_ROOT_HINT)
+ find_program(BREW brew)
+ if(BREW)
+ execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
+ OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL11_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL11_BREW_PREFIX})
+ else()
+ execute_process(COMMAND ${BREW} --prefix "openssl"
+ OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL_BREW_PREFIX})
+ endif()
+ endif()
+ endif()
+ endif()
Review Comment:
aws-c-cal will do a find_package(OpenSSL), but i'm not sure if it needs this though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429264920
Revision: d983e57c20fa6d72dc7c19a26ac9a5e6c10134b8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9fac934bc2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9fac934bc2)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4171526119/jobs/7221550144)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1432241868
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/3330d20fe4544963b6349cb13f1af61b...9f1f1b50e8b44fde8fc8893bfb295101/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430832880
Revision: d33a98f3c84779015e6a4b827ea669b300164f66
Submitted crossbow builds: [ursacomputing/crossbow @ actions-858bd84cf8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-858bd84cf8)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-858bd84cf8-azure-conda-linux-aarch64-cpu-r41)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11350662992)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11350680211)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11350667833)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11350649495)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11350668763)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11350654857)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11350659043)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11350656795)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4181263165/jobs/7243035482)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4181260136/jobs/7243029999)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4181249971/jobs/7243010080)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4181249646/jobs/7243015585)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181261857/jobs/7243032903)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4181251987/jobs/7243012949)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181263364/jobs/7243035742)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11350658349)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181249274/jobs/7243008464)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4181262180/jobs/7243033490)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4181260922/jobs/7243031403)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4181256590/jobs/7243022942)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4181252831/jobs/7243015446)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181265591/jobs/7243040065)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11350665495)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4181253224/jobs/7243016295)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11350671344)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4181256451/jobs/7243022579)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4181251235/jobs/7243011651)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4181260262/jobs/7243030429)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4181252983/jobs/7243015848)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4181256309/jobs/7243022121)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4181262909/jobs/7243034827)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4181257726/jobs/7243025170)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11350668351)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4181261293/jobs/7243032536)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4181259966/jobs/7243029586)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11350646934)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11350666411)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4181263939/jobs/7243037136)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11350648497)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11350641911)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11350648811)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11350650229)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11350661696)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11350679014)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11350682878)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4181262577/jobs/7243034156)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4181263511/jobs/7243036396)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181256907/jobs/7243023694)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4181264725/jobs/7243038694)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4181250920/jobs/7243011103)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11350667112)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181258077/jobs/7243025669)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4181250616/jobs/7243010614)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4181255741/jobs/7243020668)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4181253581/jobs/7243016842)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181264377/jobs/7243038089)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430891916
Sorry. Can we try this?
```diff
diff --git a/ci/scripts/java_jni_macos_build.sh b/ci/scripts/java_jni_macos_build.sh
index 391d05642..37bbe1283 100755
--- a/ci/scripts/java_jni_macos_build.sh
+++ b/ci/scripts/java_jni_macos_build.sh
@@ -109,6 +109,7 @@ fi
popd
+export JAVA_JNI_CMAKE_ARGS="-DProtobuf_ROOT=${build_dir}/cpp/protobuf_ep-install"
${arrow_dir}/ci/scripts/java_jni_build.sh \
${arrow_dir} \
${install_dir} \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1432008096
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427776740
Revision: cb07ab576e709e88e10af40dca4792be27e1a821
Submitted crossbow builds: [ursacomputing/crossbow @ actions-11476c8504](https://github.com/ursacomputing/crossbow/branches/all?query=actions-11476c8504)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-11476c8504-azure-conda-linux-aarch64-cpu-r41)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/tree/actions-11476c8504-azure-conda-linux-aarch64-cpu-r42)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11297310253)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11297266142)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11297319768)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11297258938)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11297250499)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11297288509)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11297311700)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4162911264/jobs/7202655006)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4162910497/jobs/7202652845)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4162896040/jobs/7202634150)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162906186/jobs/7202643400)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4162899979/jobs/7202629150)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162904436/jobs/7202639219)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11297294818)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162913204/jobs/7202658883)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4162895622/jobs/7202619226)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4162893479/jobs/7202614491)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4162898773/jobs/7202626285)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4162907443/jobs/7202646106)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162912036/jobs/7202656387)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11297264901)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4162903016/jobs/7202636424)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11297291074)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4162900361/jobs/7202630197)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4162889271/jobs/7202605564)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4162897407/jobs/7202623625)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4162895415/jobs/7202618812)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4162904877/jobs/7202640368)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4162891454/jobs/7202610456)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4162897811/jobs/7202624313)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11297309089)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4162892973/jobs/7202613876)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4162910127/jobs/7202652054)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11297303579)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11297293138)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4162899675/jobs/7202628350)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11297285117)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11297254293)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11297307503)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11297260262)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11297317360)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11297256636)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11297278087)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4162889718/jobs/7202606382)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4162896455/jobs/7202621711)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162912769/jobs/7202657986)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4162901147/jobs/7202632178)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4162896949/jobs/7202622274)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11297302829)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162907890/jobs/7202647166)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4162902100/jobs/7202634304)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4162899188/jobs/7202627230)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4162905329/jobs/7202641297)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4162890557/jobs/7202608529)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427843923
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428034041
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428187088
Revision: 67608d725ea32801874951e568c4004e404d71ff
Submitted crossbow builds: [ursacomputing/crossbow @ actions-17ec949922](https://github.com/ursacomputing/crossbow/branches/all?query=actions-17ec949922)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4165279919/jobs/7208059310)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105395455
##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -135,6 +136,7 @@ archery linking check-dependencies \
--allow libncurses \
--allow libobjc \
--allow libplasma_java \
+ --allow libprotobuf \
Review Comment:
I'm confused...... IIRC Gandiva doesn't need protobuf. https://github.com/apache/arrow/blob/master/cpp/cmake_modules/ThirdpartyToolchain.cmake#L367 This should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1427770242
Revision: cb07ab576e709e88e10af40dca4792be27e1a821
Submitted crossbow builds: [ursacomputing/crossbow @ actions-300338ea3b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-300338ea3b)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4162890235/jobs/7202608104)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428050463
Revision: e4dcae8cbebd992a47c3d79ec68ba8e1431113c2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-62cdfe6700](https://github.com/ursacomputing/crossbow/branches/all?query=actions-62cdfe6700)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11302122372)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/tree/actions-62cdfe6700-azure-conda-linux-aarch64-cpu-r42)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11302124370)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11302111287)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11302132879)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11302163790)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11302138635)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11302125761)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11302146105)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4164553460/jobs/7206340428)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4164543049/jobs/7206317637)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4164544825/jobs/7206335811)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164547644/jobs/7206327480)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4164559928/jobs/7206352886)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164532373/jobs/7206293474)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11302159298)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164542399/jobs/7206316100)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4164541193/jobs/7206313853)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4164530826/jobs/7206289528)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4164532928/jobs/7206294834)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4164533379/jobs/7206296011)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164551321/jobs/7206334812)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11302175831)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4164543536/jobs/7206318711)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11302135321)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4164556578/jobs/7206346115)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4164532037/jobs/7206292402)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4164557094/jobs/7206347707)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4164550571/jobs/7206333420)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4164535937/jobs/7206301740)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4164539920/jobs/7206311082)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4164529232/jobs/7206286297)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11302194871)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4164531396/jobs/7206291995)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4164548653/jobs/7206329761)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11302192159)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11302193262)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4164536462/jobs/7206302967)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11302156068)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11302109041)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11302167418)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11302198987)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11302133661)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11302160572)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11302178228)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4164555137/jobs/7206343480)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4164549786/jobs/7206332606)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164540547/jobs/7206312439)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4164554615/jobs/7206342279)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4164544247/jobs/7206320169)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11302197537)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164535314/jobs/7206300428)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4164545921/jobs/7206323817)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4164551863/jobs/7206335987)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4164555716/jobs/7206344370)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4164538551/jobs/7206308013)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428045505
Revision: e4dcae8cbebd992a47c3d79ec68ba8e1431113c2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3b7c157133](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3b7c157133)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4164527315/jobs/7206282214)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1428048974
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1106602445
##########
java/gandiva/CMakeLists.txt:
##########
@@ -38,6 +38,7 @@ set(GANDIVA_PROTO_DIR ${CMAKE_CURRENT_SOURCE_DIR}/proto)
get_filename_component(GANDIVA_PROTO_FILE_ABSOLUTE ${GANDIVA_PROTO_DIR}/Types.proto
ABSOLUTE)
+set(Protobuf_USE_STATIC_LIBS ON)
Review Comment:
Done.
##########
java/gandiva/CMakeLists.txt:
##########
@@ -38,6 +38,7 @@ set(GANDIVA_PROTO_DIR ${CMAKE_CURRENT_SOURCE_DIR}/proto)
get_filename_component(GANDIVA_PROTO_FILE_ABSOLUTE ${GANDIVA_PROTO_DIR}/Types.proto
ABSOLUTE)
+set(Protobuf_USE_STATIC_LIBS ON)
find_package(Protobuf REQUIRED)
if(MSVC)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430739395
> Ah, this is caused by [Homebrew/homebrew-core#122277](https://github.com/Homebrew/homebrew-core/pull/122277) . Homebrew stopped providing `libprotobuf.a`.
>
> We need to prepare `libprotobuf.a` for us. But it is not related to this pull request. Could you open a new issue for it?
Nice find! I thought of this reason but didn't find this change. I created a new issue https://github.com/apache/arrow/issues/34189 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1430862178
Revision: f44c1bfaa32386e8a3ababfb1910e4954874f366
Submitted crossbow builds: [ursacomputing/crossbow @ actions-51709d531d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-51709d531d)
|Task|Status|
|----|------|
|conda-linux-aarch64-cpu-r41|[](https://github.com/ursacomputing/crossbow/tree/actions-51709d531d-azure-conda-linux-aarch64-cpu-r41)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11351181604)|
|conda-linux-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11351193020)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11351165768)|
|conda-osx-arm64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11351197369)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11351171337)|
|conda-osx-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11351203925)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/11351174112)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/11351198592)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions/runs/4181472697/jobs/7243451924)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions/runs/4181462249/jobs/7243430091)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4181471652/jobs/7243449547)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/4181469265/jobs/7243453388)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181460501/jobs/7243426637)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/4181465295/jobs/7243436275)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181456477/jobs/7243418336)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11351198785)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181468778/jobs/7243443565)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4181457560/jobs/7243420826)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4181456248/jobs/7243417788)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4181467113/jobs/7243439659)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/4181472445/jobs/7243451041)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181461176/jobs/7243428108)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11351165067)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/4181467508/jobs/7243440493)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/11351185039)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/4181473187/jobs/7243452756)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/4181464532/jobs/7243434643)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/4181460101/jobs/7243425907)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/4181468957/jobs/7243444092)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/4181470001/jobs/7243446032)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/4181464256/jobs/7243434158)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/4181458685/jobs/7243423073)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/11351208245)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/4181460329/jobs/7243426534)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/4181462930/jobs/7243431403)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/11351188901)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/11351191113)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/4181456767/jobs/7243419043)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/11351189543)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/11351185941)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/11351168905)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/11351207439)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/11351197934)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/11351164410)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/11351210121)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/4181465963/jobs/7243437627)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/4181471344/jobs/7243448959)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181462665/jobs/7243430838)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/4181463947/jobs/7243433372)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/4181458281/jobs/7243422208)|
|test-ubuntu-18.04-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/11351174886)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181457271/jobs/7243420138)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/4181466711/jobs/7243439012)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/4181470860/jobs/7243447742)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/4181469603/jobs/7243445380)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/4181459791/jobs/7243424939)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on a diff in pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on code in PR #34159:
URL: https://github.com/apache/arrow/pull/34159#discussion_r1105259997
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4727,20 +4735,38 @@ macro(build_awssdk)
set(AWSSDK_BUILD_TYPE release)
endif()
+ # provide hint for AWS SDK to link with the already located openssl
+ get_filename_component(OPENSSL_ROOT_HINT "${OPENSSL_INCLUDE_DIR}" DIRECTORY)
+ if(APPLE AND NOT OPENSSL_ROOT_HINT)
+ find_program(BREW brew)
+ if(BREW)
+ execute_process(COMMAND ${BREW} --prefix "openssl@1.1"
+ OUTPUT_VARIABLE OPENSSL11_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL11_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL11_BREW_PREFIX})
+ else()
+ execute_process(COMMAND ${BREW} --prefix "openssl"
+ OUTPUT_VARIABLE OPENSSL_BREW_PREFIX
+ OUTPUT_STRIP_TRAILING_WHITESPACE)
+ if(OPENSSL_BREW_PREFIX)
+ set(OPENSSL_ROOT_HINT ${OPENSSL_BREW_PREFIX})
+ endif()
+ endif()
+ endif()
+ endif()
Review Comment:
I copied it from there: https://github.com/apache/arrow/pull/34159/files#diff-5cdc95f4e1b618f2f3ef10d370ce05a1ac05d9d401aecff3ccbb3d76bd366b6aL4831. Was it needed in the previous PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #34159: GH-34157: [C++] Configure bundled AWS SDK to use aws-lc instead of OpenSSL
Posted by "js8544 (via GitHub)" <gi...@apache.org>.
js8544 commented on PR #34159:
URL: https://github.com/apache/arrow/pull/34159#issuecomment-1429559603
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org