You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2016/06/07 15:14:28 UTC
[GitHub] brooklyn-ui pull request #29: Use password input for sensitive information
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-ui/pull/29
Use password input for sensitive information
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-ui hide-sensitive-information-in-effector-params
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-ui/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit bb51b6ef00632f7b3701dea6093a9b08b36e2a0b
Author: Valentin Aitken <bo...@gmail.com>
Date: 2016-06-07T15:13:35Z
Use password input for sensitive information
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request #29: Use password input for sensitive information
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-ui/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request #29: Use password input for sensitive information
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/29#discussion_r66147228
--- Diff: src/main/webapp/assets/tpl/apps/param.html ---
@@ -34,6 +34,10 @@
<input type="checkbox" class="param-value">
<% } %>
</td>
+ <% } else if (sensitive == true && type == 'java.lang.String') { %>
--- End diff --
Do we really need to check for type == String, or should we mask out anything that seems to be sensitive?
As a silly example, there code be a 4-digit pin code (which someone has represented as a number).
Presumably we can just mark it as password, get the value, and then rely on our type coercions like we do everywhere else?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #29: Use password input for sensitive information
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/29
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request #29: Use password input for sensitive information
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/29#discussion_r66115710
--- Diff: src/main/webapp/assets/tpl/apps/param.html ---
@@ -34,6 +34,10 @@
<input type="checkbox" class="param-value">
<% } %>
</td>
+ <% } else if (sensitive == true && type == 'java.lang.String') { %>
+ <td>
+ <input type="password" class="param-value">
--- End diff --
What about the default value? And maybe worth using the `input-medium` class for consistency with the case below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---