You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/07/08 23:53:03 UTC
[GitHub] [lucene] vigyasharma opened a new pull request, #1012: LUCENE-10648: Fix failures in TestAssertingPointsFormat.testWithExceptions
vigyasharma opened a new pull request, #1012:
URL: https://github.com/apache/lucene/pull/1012
When `createCompoundFile()` succeeds, it replaces all previously tracked files in segment info, with the new CFS/CFE files.
If it passes, the files created prior to writing the CFS files need to be deleted directly. However, if it fails, the calling thread in `IW.addIndexes()` deletes any pending files.
The finally block in this code was leading us to double delete those files, causing the test to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand merged pull request #1012: LUCENE-10648: Fix failures in TestAssertingPointsFormat.testWithExceptions
Posted by GitBox <gi...@apache.org>.
mikemccand merged PR #1012:
URL: https://github.com/apache/lucene/pull/1012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] vigyasharma commented on pull request #1012: LUCENE-10648: Fix failures in TestAssertingPointsFormat.testWithExceptions
Posted by GitBox <gi...@apache.org>.
vigyasharma commented on PR #1012:
URL: https://github.com/apache/lucene/pull/1012#issuecomment-1179579087
Right, we can remove the TODO, as the calling thread in addIndexes now takes care of cleaning up any pending non-CFS files. Updated the PR.
> did we change something that invalidated the comment ("they were never registered ...")?
I just reworded it to "they are not tracked anymore"..
**Some overall context:**
Any partially created files from a write failure in `createCompoundFile()` get cleaned up [inside that method](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L5741-L5749).
When we return from createCompoundFile(), we just need to delete the old non-CFS files. Since createCFS() resets `merge.info.files()`, on success, these files become untracked. So we keep them in a local variable and delete them directly. On failure, the calling thread in `addIndexes()` takes care of this deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org