You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/08 00:29:39 UTC
Review Request 65559: Updated disk profile tests for profile selector
support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65559/
-----------------------------------------------------------
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
Updated disk profile tests for profile selector support.
Diffs
-----
src/tests/disk_profile_tests.cpp b6b35ef3641b2a5b59ee2190223e1e75ef3abaaf
Diff: https://reviews.apache.org/r/65559/diff/1/
Testing
-------
sudo make check
NOTE: make check will fail for r65558 without this patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 65559: Updated disk profile tests for resource
provider selector support.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65559/#review197074
-----------------------------------------------------------
PASS: Mesos patch 65559 was successfully built and tested.
Reviews applied: `['65553', '65554', '65538', '65558', '65559']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65559
- Mesos Reviewbot Windows
On Feb. 8, 2018, 4:38 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65559/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 4:38 a.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated disk profile tests for profile selector support.
>
>
> Diffs
> -----
>
> src/tests/disk_profile_tests.cpp b6b35ef3641b2a5b59ee2190223e1e75ef3abaaf
>
>
> Diff: https://reviews.apache.org/r/65559/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
> NOTE: make check will fail for r65558 without this patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65559: Updated tests for resource provider selector
support.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65559/#review197116
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 8, 2018, 6:38 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65559/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 6:38 a.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests for resource provider selector support.
>
>
> Diffs
> -----
>
> src/tests/disk_profile_tests.cpp b6b35ef3641b2a5b59ee2190223e1e75ef3abaaf
> src/tests/storage_local_resource_provider_tests.cpp f3903089f626a0ac72268424699f642e2df32e6c
>
>
> Diff: https://reviews.apache.org/r/65559/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
> NOTE: make check will fail for r65558 without this patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65559: Updated tests for resource provider selector
support.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65559/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 6:38 a.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Summary (updated)
-----------------
Updated tests for resource provider selector support.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description (updated)
-------
Updated tests for resource provider selector support.
Diffs (updated)
-----
src/tests/disk_profile_tests.cpp b6b35ef3641b2a5b59ee2190223e1e75ef3abaaf
src/tests/storage_local_resource_provider_tests.cpp f3903089f626a0ac72268424699f642e2df32e6c
Diff: https://reviews.apache.org/r/65559/diff/3/
Changes: https://reviews.apache.org/r/65559/diff/2-3/
Testing
-------
sudo make check
NOTE: make check will fail for r65558 without this patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 65559: Updated disk profile tests for profile
selector support.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65559/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 4:38 a.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
Updated disk profile tests for profile selector support.
Diffs (updated)
-----
src/tests/disk_profile_tests.cpp b6b35ef3641b2a5b59ee2190223e1e75ef3abaaf
Diff: https://reviews.apache.org/r/65559/diff/2/
Changes: https://reviews.apache.org/r/65559/diff/1-2/
Testing
-------
sudo make check
NOTE: make check will fail for r65558 without this patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 65559: Updated disk profile tests for profile
selector support.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65559/#review197065
-----------------------------------------------------------
PASS: Mesos patch 65559 was successfully built and tested.
Reviews applied: `['65553', '65554', '65538', '65558', '65559']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65559
- Mesos Reviewbot Windows
On Feb. 8, 2018, 12:29 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65559/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 12:29 a.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated disk profile tests for profile selector support.
>
>
> Diffs
> -----
>
> src/tests/disk_profile_tests.cpp b6b35ef3641b2a5b59ee2190223e1e75ef3abaaf
>
>
> Diff: https://reviews.apache.org/r/65559/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> NOTE: make check will fail for r65558 without this patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>