You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/07 12:56:21 UTC

[GitHub] [shardingsphere-elasticjob] pandaapo opened a new pull request, #2112: Fix the issue #2105: NullPointerExecption caused by job configuration…

pandaapo opened a new pull request, #2112:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2112

   Fixes #2105.
   
   Changes proposed in this pull request:
   - When no job configuration can be loaded, throw more readable JobConfigurationExecption, not NullPointerExecption. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #2112: Fix the issue #2105: NullPointerExecption caused by job configuration…

Posted by GitBox <gi...@apache.org>.
TeslaCN merged PR #2112:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #2112: Fix the issue #2105: NullPointerExecption caused by job configuration…

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2112:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2112#issuecomment-1207595445

   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2112](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fba3b16) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/8eac50adba90c029e109107a9243a5980931a367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8eac50a) will **decrease** coverage by `0.02%`.
   > The diff coverage is `33.33%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2112      +/-   ##
   ============================================
   - Coverage     85.27%   85.24%   -0.03%     
   + Complexity     1893     1890       -3     
   ============================================
     Files           282      281       -1     
     Lines          6158     6100      -58     
     Branches        736      666      -70     
   ============================================
   - Hits           5251     5200      -51     
   - Misses          566      591      +25     
   + Partials        341      309      -32     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...job/lite/internal/config/ConfigurationService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvY29uZmlnL0NvbmZpZ3VyYXRpb25TZXJ2aWNlLmphdmE=) | `87.87% <33.33%> (-5.67%)` | :arrow_down: |
   | [...re/elasticjob/lite/internal/server/ServerNode.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2VydmVyL1NlcnZlck5vZGUuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...te/internal/setup/JobClassNameProviderFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2V0dXAvSm9iQ2xhc3NOYW1lUHJvdmlkZXJGYWN0b3J5LmphdmE=) | `42.85% <0.00%> (-14.29%)` | :arrow_down: |
   | [...ob/restful/pipeline/FilterChainInboundHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9GaWx0ZXJDaGFpbkluYm91bmRIYW5kbGVyLmphdmE=) | `75.00% <0.00%> (-12.50%)` | :arrow_down: |
   | [...ticjob/cloud/executor/local/LocalTaskExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1jbG91ZC9lbGFzdGljam9iLWNsb3VkLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2Nsb3VkL2V4ZWN1dG9yL2xvY2FsL0xvY2FsVGFza0V4ZWN1dG9yLmphdmE=) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
   | [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `91.66% <0.00%> (-8.34%)` | :arrow_down: |
   | [...sphere/elasticjob/executor/ElasticJobExecutor.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1leGVjdXRvci9lbGFzdGljam9iLWV4ZWN1dG9yLWtlcm5lbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9leGVjdXRvci9FbGFzdGljSm9iRXhlY3V0b3IuamF2YQ==) | `86.81% <0.00%> (-4.59%)` | :arrow_down: |
   | [...l/deserializer/RequestBodyDeserializerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9kZXNlcmlhbGl6ZXIvUmVxdWVzdEJvZHlEZXNlcmlhbGl6ZXJGYWN0b3J5LmphdmE=) | `76.92% <0.00%> (-3.85%)` | :arrow_down: |
   | [...ener/AbstractDistributeOnceElasticJobListener.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL2xpc3RlbmVyL0Fic3RyYWN0RGlzdHJpYnV0ZU9uY2VFbGFzdGljSm9iTGlzdGVuZXIuamF2YQ==) | `79.31% <0.00%> (-3.45%)` | :arrow_down: |
   | [...asticjob/lite/internal/storage/JobNodeStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlU3RvcmFnZS5qYXZh) | `95.34% <0.00%> (-2.33%)` | :arrow_down: |
   | ... and [41 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2112/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org