You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by ma...@apache.org on 2013/07/24 11:44:36 UTC
svn commit: r1506468 - /bloodhound/trunk/trac/trac/ticket/model.py
Author: matevz
Date: Wed Jul 24 09:44:36 2013
New Revision: 1506468
URL: http://svn.apache.org/r1506468
Log:
removed print statement
Modified:
bloodhound/trunk/trac/trac/ticket/model.py
Modified: bloodhound/trunk/trac/trac/ticket/model.py
URL: http://svn.apache.org/viewvc/bloodhound/trunk/trac/trac/ticket/model.py?rev=1506468&r1=1506467&r2=1506468&view=diff
==============================================================================
--- bloodhound/trunk/trac/trac/ticket/model.py (original)
+++ bloodhound/trunk/trac/trac/ticket/model.py Wed Jul 24 09:44:36 2013
@@ -226,7 +226,6 @@ class Ticket(object):
# Insert ticket record
std_fields = []
custom_fields = []
- print self.values
for f in self.fields:
fname = f['name']
if fname in self.values:
Re: svn commit: r1506468 - /bloodhound/trunk/trac/trac/ticket/model.py
Posted by Gary Martin <ga...@wandisco.com>.
On 25/07/13 10:40, Matevž Bradač wrote:
> On 25. Jul, 2013, at 11:25, Ryan Ollos wrote:
>
>> On Wed, Jul 24, 2013 at 2:44 AM, <ma...@apache.org> wrote:
>>
>>> Author: matevz
>>> Date: Wed Jul 24 09:44:36 2013
>>> New Revision: 1506468
>>>
>>> URL: http://svn.apache.org/r1506468
>>> Log:
>>> removed print statement
>>>
>>> Modified:
>>> bloodhound/trunk/trac/trac/ticket/model.py
>>>
>>> Modified: bloodhound/trunk/trac/trac/ticket/model.py
>>> URL:
>>> http://svn.apache.org/viewvc/bloodhound/trunk/trac/trac/ticket/model.py?rev=1506468&r1=1506467&r2=1506468&view=diff
>>>
>>> ==============================================================================
>>> --- bloodhound/trunk/trac/trac/ticket/model.py (original)
>>> +++ bloodhound/trunk/trac/trac/ticket/model.py Wed Jul 24 09:44:36 2013
>>> @@ -226,7 +226,6 @@ class Ticket(object):
>>> # Insert ticket record
>>> std_fields = []
>>> custom_fields = []
>>> - print self.values
>>> for f in self.fields:
>>> fname = f['name']
>>> if fname in self.values:
>>>
>> Thanks for catching that. I must have done the reverse merge in r1505871
>> into a dirty working copy, but I'm used to Subversion warning me about such
>> things ... (or maybe that is only TortoieseSVN that warns?).
> No worries, accidentally spotted when running unit tests.
>
>> Anyway, that is what I get for being lazy and putting a print statement
>> rather than attaching the debugger!
>
> I wouldn't say lazy, it's a matter of practicality. =)
> Adding print statements is usually a lot faster than using a debugger,
> and there's always an off chance that a debugger also has its own bugs.
> I usually prefix the print output, e.g.:
> print '###', self.values
> and then grep for '###' before committing.
>
I tend to throw in an import pdb; pdb.set_trace() for my debugging which
is also worth looking out for!
Cheers,
Gary
Re: svn commit: r1506468 - /bloodhound/trunk/trac/trac/ticket/model.py
Posted by Matevž Bradač <ma...@digiverse.si>.
On 25. Jul, 2013, at 11:25, Ryan Ollos wrote:
> On Wed, Jul 24, 2013 at 2:44 AM, <ma...@apache.org> wrote:
>
>> Author: matevz
>> Date: Wed Jul 24 09:44:36 2013
>> New Revision: 1506468
>>
>> URL: http://svn.apache.org/r1506468
>> Log:
>> removed print statement
>>
>> Modified:
>> bloodhound/trunk/trac/trac/ticket/model.py
>>
>> Modified: bloodhound/trunk/trac/trac/ticket/model.py
>> URL:
>> http://svn.apache.org/viewvc/bloodhound/trunk/trac/trac/ticket/model.py?rev=1506468&r1=1506467&r2=1506468&view=diff
>>
>> ==============================================================================
>> --- bloodhound/trunk/trac/trac/ticket/model.py (original)
>> +++ bloodhound/trunk/trac/trac/ticket/model.py Wed Jul 24 09:44:36 2013
>> @@ -226,7 +226,6 @@ class Ticket(object):
>> # Insert ticket record
>> std_fields = []
>> custom_fields = []
>> - print self.values
>> for f in self.fields:
>> fname = f['name']
>> if fname in self.values:
>>
>
> Thanks for catching that. I must have done the reverse merge in r1505871
> into a dirty working copy, but I'm used to Subversion warning me about such
> things ... (or maybe that is only TortoieseSVN that warns?).
No worries, accidentally spotted when running unit tests.
>
> Anyway, that is what I get for being lazy and putting a print statement
> rather than attaching the debugger!
I wouldn't say lazy, it's a matter of practicality. =)
Adding print statements is usually a lot faster than using a debugger,
and there's always an off chance that a debugger also has its own bugs.
I usually prefix the print output, e.g.:
print '###', self.values
and then grep for '###' before committing.
Re: svn commit: r1506468 - /bloodhound/trunk/trac/trac/ticket/model.py
Posted by Ryan Ollos <ry...@wandisco.com>.
On Wed, Jul 24, 2013 at 2:44 AM, <ma...@apache.org> wrote:
> Author: matevz
> Date: Wed Jul 24 09:44:36 2013
> New Revision: 1506468
>
> URL: http://svn.apache.org/r1506468
> Log:
> removed print statement
>
> Modified:
> bloodhound/trunk/trac/trac/ticket/model.py
>
> Modified: bloodhound/trunk/trac/trac/ticket/model.py
> URL:
> http://svn.apache.org/viewvc/bloodhound/trunk/trac/trac/ticket/model.py?rev=1506468&r1=1506467&r2=1506468&view=diff
>
> ==============================================================================
> --- bloodhound/trunk/trac/trac/ticket/model.py (original)
> +++ bloodhound/trunk/trac/trac/ticket/model.py Wed Jul 24 09:44:36 2013
> @@ -226,7 +226,6 @@ class Ticket(object):
> # Insert ticket record
> std_fields = []
> custom_fields = []
> - print self.values
> for f in self.fields:
> fname = f['name']
> if fname in self.values:
>
Thanks for catching that. I must have done the reverse merge in r1505871
into a dirty working copy, but I'm used to Subversion warning me about such
things ... (or maybe that is only TortoieseSVN that warns?).
Anyway, that is what I get for being lazy and putting a print statement
rather than attaching the debugger!