You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Edouard Hue (JIRA)" <ji...@apache.org> on 2011/07/21 00:03:57 UTC

[jira] [Created] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Permit using different tablespaces for tables and indexes with Oracle
---------------------------------------------------------------------

                 Key: JCR-3030
                 URL: https://issues.apache.org/jira/browse/JCR-3030
             Project: Jackrabbit Content Repository
          Issue Type: Improvement
          Components: jackrabbit-core, sql
    Affects Versions: 2.3.0
            Reporter: Edouard Hue
            Priority: Minor


OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Updated] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by Edouard Hue <ed...@gmail.com>.
Hi Jukka,

I just submitted an updated patch.

Edouard

On Tue, Sep 27, 2011 at 11:34 PM, Jukka Zitting (Updated) (JIRA) <
jira@apache.org> wrote:

>
>     [
> https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Jukka Zitting updated JCR-3030:
> -------------------------------
>
>    Fix Version/s:     (was: 2.3.0)
>           Status: Open  (was: Patch Available)
>
> Sorry for the late response.
>
> I like the idea and the fact that you included a test case with the patch.
> The only thing I'd like to see added before we commit this is restoring
> backwards compatibility with existing repository configurations. For
> example, if someone has already configured a repository with the current
> tableSpace parameter, it should automatically be used for both the new
> tablespace variables instead of throwing a configuration error as it would
> with the proposed patch.
>
> > Permit using different tablespaces for tables and indexes with Oracle
> > ---------------------------------------------------------------------
> >
> >                 Key: JCR-3030
> >                 URL: https://issues.apache.org/jira/browse/JCR-3030
> >             Project: Jackrabbit Content Repository
> >          Issue Type: Improvement
> >          Components: jackrabbit-core, sql
> >    Affects Versions: 2.3.0
> >            Reporter: Edouard Hue
> >            Priority: Minor
> >         Attachments: JCR-3030.patch
> >
> >
> > OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal
> already provide a tableSpace parameter to customize the DDL, but the same
> tablespace is used for both tables and indexes. It is common place to use
> distinct tablespaces for these. Jackrabbit could provide support for this.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>

[jira] [Updated] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by "Edouard Hue (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edouard Hue updated JCR-3030:
-----------------------------

    Attachment: JCR-3030.patch

Patch with unit tests

> Permit using different tablespaces for tables and indexes with Oracle
> ---------------------------------------------------------------------
>
>                 Key: JCR-3030
>                 URL: https://issues.apache.org/jira/browse/JCR-3030
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, sql
>    Affects Versions: 2.3.0
>            Reporter: Edouard Hue
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: JCR-3030.patch
>
>
> OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by "Jukka Zitting (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-3030:
-------------------------------

    Fix Version/s:     (was: 2.3.0)
           Status: Open  (was: Patch Available)

Sorry for the late response.

I like the idea and the fact that you included a test case with the patch. The only thing I'd like to see added before we commit this is restoring backwards compatibility with existing repository configurations. For example, if someone has already configured a repository with the current tableSpace parameter, it should automatically be used for both the new tablespace variables instead of throwing a configuration error as it would with the proposed patch.
                
> Permit using different tablespaces for tables and indexes with Oracle
> ---------------------------------------------------------------------
>
>                 Key: JCR-3030
>                 URL: https://issues.apache.org/jira/browse/JCR-3030
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, sql
>    Affects Versions: 2.3.0
>            Reporter: Edouard Hue
>            Priority: Minor
>         Attachments: JCR-3030.patch
>
>
> OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by "Edouard Hue (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edouard Hue updated JCR-3030:
-----------------------------

    Attachment:     (was: JCR-3030.patch)
    
> Permit using different tablespaces for tables and indexes with Oracle
> ---------------------------------------------------------------------
>
>                 Key: JCR-3030
>                 URL: https://issues.apache.org/jira/browse/JCR-3030
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, sql
>    Affects Versions: 2.3.0
>            Reporter: Edouard Hue
>            Priority: Minor
>         Attachments: JCR-3030.patch
>
>
> OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by "Edouard Hue (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068667#comment-13068667 ] 

Edouard Hue commented on JCR-3030:
----------------------------------

I have already starting working on a patch, still needs a little testing.

> Permit using different tablespaces for tables and indexes with Oracle
> ---------------------------------------------------------------------
>
>                 Key: JCR-3030
>                 URL: https://issues.apache.org/jira/browse/JCR-3030
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, sql
>    Affects Versions: 2.3.0
>            Reporter: Edouard Hue
>            Priority: Minor
>
> OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by "Jukka Zitting (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-3030.
--------------------------------

    Resolution: Fixed
      Assignee: Jukka Zitting

Great work, thanks! Patch committed in revision 1179984.
                
> Permit using different tablespaces for tables and indexes with Oracle
> ---------------------------------------------------------------------
>
>                 Key: JCR-3030
>                 URL: https://issues.apache.org/jira/browse/JCR-3030
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, sql
>    Affects Versions: 2.3
>            Reporter: Edouard Hue
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 2.3.1
>
>         Attachments: JCR-3030.patch
>
>
> OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by "Edouard Hue (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edouard Hue updated JCR-3030:
-----------------------------

    Fix Version/s: 2.3.0
           Status: Patch Available  (was: Open)

Patch for jackrabbit-core (rev. 1149180). Affects :
- org.apache.jackrabbit.core.fs.db.OracleFileSystem
- org.apache.jackrabbit.core.journal.OracleDatabaseJournal
- org.apache.jackrabbit.core.persistence.pool.OraclePersistenceManager
and associated oracle.ddl resources.

The old "tableSpace" replacement variable is replaced with "tableTablespace" and "indexTablespace" variables and matching getters/setters.

Also included are two unit tests :
- org.apache.jackrabbit.core.fs.db.OracleFileSystemTest, similar to DerbyFileSystemTest
- org.apache.jackrabbit.core.OracleRepositoryTest with org.apache.jackrabbit.core.repository-oracle.xml : starts and logins to a transient repository using the three classes above.
Both unit tests expect a bunch of system properties to retrieve the database connection parameters. I chose not to hardcode them as I have no idea of what databases are available to CI builds.

> Permit using different tablespaces for tables and indexes with Oracle
> ---------------------------------------------------------------------
>
>                 Key: JCR-3030
>                 URL: https://issues.apache.org/jira/browse/JCR-3030
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, sql
>    Affects Versions: 2.3.0
>            Reporter: Edouard Hue
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: JCR-3030.patch
>
>
> OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by "Edouard Hue (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edouard Hue updated JCR-3030:
-----------------------------

    Attachment: JCR-3030.patch

Updated patch with restored backward compatibility with configuration files and two relative unit tests.
                
> Permit using different tablespaces for tables and indexes with Oracle
> ---------------------------------------------------------------------
>
>                 Key: JCR-3030
>                 URL: https://issues.apache.org/jira/browse/JCR-3030
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, sql
>    Affects Versions: 2.3.0
>            Reporter: Edouard Hue
>            Priority: Minor
>         Attachments: JCR-3030.patch
>
>
> OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3030) Permit using different tablespaces for tables and indexes with Oracle

Posted by "Edouard Hue (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edouard Hue updated JCR-3030:
-----------------------------

    Fix Version/s: 2.3.1
    
> Permit using different tablespaces for tables and indexes with Oracle
> ---------------------------------------------------------------------
>
>                 Key: JCR-3030
>                 URL: https://issues.apache.org/jira/browse/JCR-3030
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, sql
>    Affects Versions: 2.3
>            Reporter: Edouard Hue
>            Priority: Minor
>             Fix For: 2.3.1
>
>         Attachments: JCR-3030.patch
>
>
> OracleFileSystem, OraclePersistenceManager and OracleDatabaseJournal already provide a tableSpace parameter to customize the DDL, but the same tablespace is used for both tables and indexes. It is common place to use distinct tablespaces for these. Jackrabbit could provide support for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira