[GitHub] [pulsar] lhotari commented on a diff in pull request #18334: [fix][client] Support LocalDateTime Conversion

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #18334:
URL: https://github.com/apache/pulsar/pull/18334#discussion_r1013801001


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java:
##########
@@ -118,6 +118,8 @@ public static void addLogicalTypeConversions(ReflectData reflectData, boolean js
         reflectData.addLogicalTypeConversion(new TimeConversions.DateConversion());
         reflectData.addLogicalTypeConversion(new TimeConversions.TimeMillisConversion());
         reflectData.addLogicalTypeConversion(new TimeConversions.TimeMicrosConversion());
+        reflectData.addLogicalTypeConversion(new TimeConversions.LocalTimestampMicrosConversion());
+        reflectData.addLogicalTypeConversion(new TimeConversions.LocalTimestampMillisConversion());

Review Comment:
   why weren't these put under the if statement `if (jsr310ConversionEnabled) {` ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org