[GitHub] [hive] deniskuzZ commented on a diff in pull request #3514: HIVE-26404: HMS memory leak when compaction cleaner fails to remove obsolete files

[GitBox <gi...@apache.org>]

deniskuzZ commented on code in PR #3514:
URL: https://github.com/apache/hive/pull/3514#discussion_r974126899


##########
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/CompactorTest.java:
##########
@@ -181,7 +184,7 @@ protected Table newTable(String dbName, String tableName, boolean partitioned,
     table.setTableName(tableName);
     table.setDbName(dbName);
     table.setOwner("me");
-    table.setSd(newStorageDescriptor(getLocation(tableName, null), sortCols));
+    table.setSd(newStorageDescriptor(getLocation(tableName, null).toString(), sortCols));

Review Comment:
   minor: getLocation returning String was more natural here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org