You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jsoref <gi...@git.apache.org> on 2014/03/27 03:05:09 UTC
[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-cli/pull/153
CB-6357 platform check - install each platform to determine working + version number
The other changesets (Refactor, exports, silence output, sort output, fix indentation) are split because it's a lot easier to understand things individually.
The evolution here is partially w/ an eye to eventually have these functions be usable by other entities too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry/cordova-cli cb_6357
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit b5d8ce7915e3875d427acb1583cb46fd046f238e
Author: Josh Soref <js...@blackberry.com>
Date: 2014-03-24T21:29:57Z
CB-6357 platform: Refactor into distinct functions
commit bca4b6fef31364cbb4d8977a52881316a30321b9
Author: Josh Soref <js...@blackberry.com>
Date: 2014-03-24T21:30:46Z
CB-6357 platform: provide exports for functions
commit 5911893d8f29e0d8341583c075b8152d359e428b
Author: Josh Soref <js...@blackberry.com>
Date: 2014-03-27T01:49:03Z
CB-6357 call_into_create: support no output
commit a67a478ec7dcff6c93bcf1c42d30e3d6653cd00b
Author: Josh Soref <js...@blackberry.com>
Date: 2014-03-26T14:43:21Z
CB-6357 platform check - install each platform to determine working + version number
commit 66cb9612a98df47d82ce6bc123be3ce4fca855a3
Author: Josh Soref <js...@blackberry.com>
Date: 2014-03-27T01:55:14Z
CB-6357 platform check: sort output
commit 6000ba91151a2ef1bc465b97f6e8fda20e660b45
Author: Josh Soref <js...@blackberry.com>
Date: 2014-03-27T01:56:44Z
CB-6357 platform: fix indentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-cli/pull/153#issuecomment-38767269
ok, with #150 applied, this set of changes applies cleanly and doesn't introduce any new `npm test` failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-cli/pull/153#issuecomment-38762210
Sigh, and now i need to deal w/ `npm test`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-cli/pull/153#issuecomment-38866049
I've merged this in. Hopefully this gets closed in a few minutes by asf script
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---