[GitHub] [spark] viirya commented on a change in pull request #34051: [WIP][SPARK-36809][SQL] Remove broadcast for InSubqueryExec used in DPP

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #34051:
URL: https://github.com/apache/spark/pull/34051#discussion_r712538558



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -104,17 +104,18 @@ case class ScalarSubquery(
 }
 
 /**
- * The physical node of in-subquery. This is for Dynamic Partition Pruning only, as in-subquery

Review comment:
       Obviously, this looks wrong as there is non-DPP case for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org