You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/09 07:14:27 UTC
[GitHub] [flink] KarmaGYZ commented on a change in pull request #11615:
[FLINK-16605] Add max limitation to the total number of slots
KarmaGYZ commented on a change in pull request #11615: [FLINK-16605] Add max limitation to the total number of slots
URL: https://github.com/apache/flink/pull/11615#discussion_r406001414
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -375,6 +375,12 @@ public void registerTaskManager(final TaskExecutorConnection taskExecutorConnect
if (taskManagerRegistrations.containsKey(taskExecutorConnection.getInstanceID())) {
reportSlotStatus(taskExecutorConnection.getInstanceID(), initialSlotReport);
} else {
+ if (getNumberRegisteredSlots() + Math.max(getNumberPendingTaskManagerSlots(), numSlotsPerWorker) > maxSlotNum) {
+ LOG.warn("The total number of slots exceeds the max limitation, release the excess resource.");
+ resourceActions.releaseResource(taskExecutorConnection.getInstanceID(), new FlinkException("The total number of slots exceeds the max limitation."));
+ return;
+ }
Review comment:
I think we could edit the contract of `ResourceActions#releaseResource`, let it return whether the release action succeeds. For `StandaloneResourceManager`, it would return false. In this case, it probably makes sense to continue to register the `reportedSlots`. So that, the slot manager need not be aware of whether it's running in a Standalone- or YarnResourceManager. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services