You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/09 19:37:27 UTC
[GitHub] [druid] loquisgon commented on a change in pull request #11419: Add the error message in taskStatus for task failures in overlord
loquisgon commented on a change in pull request #11419:
URL: https://github.com/apache/druid/pull/11419#discussion_r667171845
##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
##########
@@ -540,7 +540,9 @@ public boolean isWorkerRunningTask(ZkWorker worker, String taskId)
} else if ((completeTask = completeTasks.get(task.getId())) != null) {
return completeTask.getResult();
} else {
- return addPendingTask(task).getResult();
+ RemoteTaskRunnerWorkItem workItem = addPendingTask(task);
+ runPendingTasks();
Review comment:
I find it confusing and error prone that after adding a task(s) now you have to explicitly call run..., maybe ad a comment to make it clear that it is required (else?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org