You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Russell Morrisey (JIRA)" <ji...@apache.org> on 2010/03/05 22:57:27 UTC
[jira] Commented: (WICKET-2734) Form#anyComponentError change in
1.4 breaks validation
[ https://issues.apache.org/jira/browse/WICKET-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842042#action_12842042 ]
Russell Morrisey commented on WICKET-2734:
------------------------------------------
Forward-ported the fix to my local copy, and verified that this does correct the issue. Thanks!
> Form#anyComponentError change in 1.4 breaks validation
> ------------------------------------------------------
>
> Key: WICKET-2734
> URL: https://issues.apache.org/jira/browse/WICKET-2734
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4-M1, 1.4-M2, 1.4-M3, 1.4-RC1, 1.4-RC2, 1.4-RC3, 1.4-RC4, 1.4-RC5, 1.4-RC6, 1.4-RC7, 1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.4.6
> Environment: wicket 1.4.5
> Reporter: Russell Morrisey
> Assignee: Juergen Donnerstag
> Fix For: 1.4.7, 1.5-M1
>
> Attachments: anyComponentErrorTest.zip
>
>
> In wicket 1.4, Form#anyComponentError was changed so that it only calls hasErrorMessage() on instances of Form or FormComponent. This is a validation-breaking change. Currently, when Component#error(...) is called for any component which is neither a Form nor FormComponent, the error is ignored by a Form#hasError() check on the form containing this component. Please change it back to check any Component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.