You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/01/09 20:59:12 UTC

[kudu-CR](branch-1.2.x) [doc] KUDU-1810 Missing part of text in kudu impala create table doc section

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5642

Change subject: [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section
......................................................................

[doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section

Asciidoc was considering * as special markup for formatted
text and highlighting text in between.

Added formatting as `{asterisk}` to the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly

Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
Reviewed-on: http://gerrit.cloudera.org:8080/5639
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
(cherry picked from commit 5dd962f82f21a8e9876d356f15b293409949a084)
---
M docs/kudu_impala_integration.adoc
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/5642/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Ninad Shringarpure <ni...@cloudera.com>

[kudu-CR](branch-1.2.x) [doc] KUDU-1810 Missing part of text in kudu impala create table doc section

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section
......................................................................


[doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section

Asciidoc was considering * as special markup for formatted
text and highlighting text in between.

Added formatting as `{asterisk}` to the markup to read the text as:
If the default projection generated by * does not
meet this requirement, the user should avoid using *
and explicitly

Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
Reviewed-on: http://gerrit.cloudera.org:8080/5639
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
(cherry picked from commit 5dd962f82f21a8e9876d356f15b293409949a084)
Reviewed-on: http://gerrit.cloudera.org:8080/5642
---
M docs/kudu_impala_integration.adoc
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR](branch-1.2.x) [doc] KUDU-1810 Missing part of text in kudu impala create table doc section

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [doc] KUDU-1810 Missing part of text in kudu_impala_create_table doc section
......................................................................


Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If131a001d1835e5da58bbb167673d6df1f8132b7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Ninad Shringarpure <ni...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No