You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/06/01 22:28:36 UTC

Review Request 34902: Hadoop Home Directory Should Be Chosen Correctly During An Upgrade

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34902/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-11594
    https://issues.apache.org/jira/browse/AMBARI-11594


Repository: ambari


Description
-------

During an upgrade, some of the components are using an incorrect value for the hadoop home directory. We currently have a pattern that we use for lib/libexec/bin/sbin ... we should extend this to "home" as well to make our params.py consistent.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 31b1625 
  ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5f3c848 
  ambari-server/src/main/java/org/apache/ambari/server/Role.java 32c025c 
  ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java 587f806 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py b9b248d 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 74d00cb 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4e43b3b 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py b365397 
  ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py bef1e29 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 942b171 
  ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 075aa7b 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py a197a4d 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 97c9996 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py d801879 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py d4a0400 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py 52fa53f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py bec2545 

Diff: https://reviews.apache.org/r/34902/diff/


Testing
-------

Upgraded a cluster from HDP 2.2 and 2.3 and inspected the paths of upgraded processes:


Thanks,

Jonathan Hurley


Re: Review Request 34902: Hadoop Home Directory Should Be Chosen Correctly During An Upgrade

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34902/#review86084
-----------------------------------------------------------

Ship it!



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
<https://reviews.apache.org/r/34902/#comment137979>

    Thank you!


- Nate Cole


On June 1, 2015, 4:28 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34902/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 4:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11594
>     https://issues.apache.org/jira/browse/AMBARI-11594
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During an upgrade, some of the components are using an incorrect value for the hadoop home directory. We currently have a pattern that we use for lib/libexec/bin/sbin ... we should extend this to "home" as well to make our params.py consistent.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 31b1625 
>   ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py 5f3c848 
>   ambari-server/src/main/java/org/apache/ambari/server/Role.java 32c025c 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/ActionMetadata.java 587f806 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py b9b248d 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 74d00cb 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 4e43b3b 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py b365397 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py bef1e29 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 942b171 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py 075aa7b 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py a197a4d 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py 97c9996 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py d801879 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py d4a0400 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py 52fa53f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py bec2545 
> 
> Diff: https://reviews.apache.org/r/34902/diff/
> 
> 
> Testing
> -------
> 
> Upgraded a cluster from HDP 2.2 and 2.3 and inspected the paths of upgraded processes:
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>