You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Saavan Nanavati (Jira)" <ji...@apache.org> on 2020/08/16 22:24:00 UTC

[jira] [Commented] (BEAM-10711) Apply type hints for all transforms in the PerformanceTypeCheckVisitor

    [ https://issues.apache.org/jira/browse/BEAM-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178648#comment-17178648 ] 

Saavan Nanavati commented on BEAM-10711:
----------------------------------------

This has been fixed.

> Apply type hints for all transforms in the PerformanceTypeCheckVisitor
> ----------------------------------------------------------------------
>
>                 Key: BEAM-10711
>                 URL: https://issues.apache.org/jira/browse/BEAM-10711
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Saavan Nanavati
>            Assignee: Saavan Nanavati
>            Priority: P2
>
> Currently, we only extract type hints from ParDo transforms for the performance_runtime_ type_check flag. We should be able to remove the isinstance(transform, core.ParDo) check and use the PerformanceTypeCheckVisitor to visit and extract type hints from all transform types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)