You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Leo Sutic <le...@inspireinfrastructure.com> on 2003/04/23 21:49:27 UTC

[PATCH] SlideSource 

The SlideSource.java in current CVS doesn't compile with the latest
excalibur jars (the release candidate).

Patch that fixes:

@@ -662,13 +662,12 @@
      *
      * @return True, if the delete operation was successful.
      */
-    public boolean delete() {
+    public void delete() {
         try {
             nat.begin();
             this.macro.delete(slideToken,
                               this.config.getFilesPath()+this.path);
             nat.commit();
-            return true;
         } catch (Exception se) {
             getLogger().error("Could not delete source.",se);
             try {
@@ -676,7 +675,6 @@
             } catch (Exception rbe) {
                 getLogger().error("Rollback failed for moving source",
rbe);
             }
-            return false;
         }
     }

essentially - remove return statements and change return type to void.

/LS

Re: [PATCH] SlideSource

Posted by Stephan Michels <st...@apache.org>.

On Wed, 23 Apr 2003, Leo Sutic wrote:

> The SlideSource.java in current CVS doesn't compile with the latest
> excalibur jars (the release candidate).
>
> Patch that fixes:
>
> @@ -662,13 +662,12 @@
>       *
>       * @return True, if the delete operation was successful.
>       */
> -    public boolean delete() {
> +    public void delete() {
>          try {
>              nat.begin();
>              this.macro.delete(slideToken,
>                                this.config.getFilesPath()+this.path);
>              nat.commit();
> -            return true;
>          } catch (Exception se) {
>              getLogger().error("Could not delete source.",se);
>              try {
> @@ -676,7 +675,6 @@
>              } catch (Exception rbe) {
>                  getLogger().error("Rollback failed for moving source",
> rbe);
>              }
> -            return false;
>          }
>      }
>
> essentially - remove return statements and change return type to void.

Okay, but in the current CVS we do have an old version of the libs. So
in this way we must also update the Excalibur Sourcersolve package.

Carsten, anything against?

Stephan.