You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/02 03:52:00 UTC
[GitHub] [pulsar] congbobo184 commented on a diff in pull request #15654: [admin][txn] Add transaction admin to get recover time in stats.
congbobo184 commented on code in PR #15654:
URL: https://github.com/apache/pulsar/pull/15654#discussion_r887450482
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -147,6 +150,7 @@ private void initPendingAckStore() {
this.pendingAckStoreFuture =
pendingAckStoreProvider.newPendingAckStore(persistentSubscription);
this.pendingAckStoreFuture.thenAccept(pendingAckStore -> {
+ recoverTime.setRecoverStartTime(System.currentTimeMillis());
Review Comment:
It's better to set RecoverStartTime in checkInitializedBefore
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -861,18 +865,26 @@ public CompletableFuture<PendingAckHandle> pendingAckHandleFuture() {
public TransactionPendingAckStats getStats() {
TransactionPendingAckStats transactionPendingAckStats = new TransactionPendingAckStats();
transactionPendingAckStats.state = this.getState().name();
+ transactionPendingAckStats.recoverStartTime = recoverTime.getRecoverStartTime();
+ transactionPendingAckStats.recoverEndTime = recoverTime.getRecoverEndTime();
return transactionPendingAckStats;
}
public synchronized void completeHandleFuture() {
if (!this.pendingAckHandleCompletableFuture.isDone()) {
this.pendingAckHandleCompletableFuture.complete(PendingAckHandleImpl.this);
}
+ if (recoverTime.getRecoverStartTime() == 0L) {
Review Comment:
all should setRecoverEndTime
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -861,18 +865,26 @@ public CompletableFuture<PendingAckHandle> pendingAckHandleFuture() {
public TransactionPendingAckStats getStats() {
TransactionPendingAckStats transactionPendingAckStats = new TransactionPendingAckStats();
transactionPendingAckStats.state = this.getState().name();
+ transactionPendingAckStats.recoverStartTime = recoverTime.getRecoverStartTime();
+ transactionPendingAckStats.recoverEndTime = recoverTime.getRecoverEndTime();
return transactionPendingAckStats;
}
public synchronized void completeHandleFuture() {
if (!this.pendingAckHandleCompletableFuture.isDone()) {
this.pendingAckHandleCompletableFuture.complete(PendingAckHandleImpl.this);
}
+ if (recoverTime.getRecoverStartTime() == 0L) {
+ return;
+ } else {
+ recoverTime.setRecoverEndTime(System.currentTimeMillis());
+ }
}
public synchronized void exceptionHandleFuture(Throwable t) {
if (!this.pendingAckHandleCompletableFuture.isDone()) {
this.pendingAckHandleCompletableFuture.completeExceptionally(t);
+ recoverTime.setRecoverEndTime(-1L);
Review Comment:
if recover fail, also should setRecoverEndTime
##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TransactionBufferStats.java:
##########
@@ -28,4 +28,9 @@ public class TransactionBufferStats {
/** The last snapshot timestamps of this transaction buffer. */
public long lastSnapshotTimestamps;
+
+ //Start timestamp of transaction buffer recovery. 0L means no startup.
+ public long recoverStartTime;
+ //End timestamp of transaction buffer recovery. 0L means no startup, -1L means exceptionally.
Review Comment:
don't need set -1, TxnBufferState has already expressed, same above pendingAck and Tc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org