You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/12/09 18:52:22 UTC
[kudu-CR] Make tablet copy-itest less flaky
Hello Dinesh Bhat, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5441
to review the following change.
Change subject: Make tablet_copy-itest less flaky
......................................................................
Make tablet_copy-itest less flaky
The test TestDisableTabletCopy_NoTightLoopWhenTabletDeleted sometimes
sleeps longer than 1 second when we call SleepFor() due to system load,
so we average our "per second" calculation over the time actually
elapsed.
Also bump slightly the number of log messages we tolerate due to
spurious log messages for unrelated components.
Change-Id: I5132d3ea99a8ecd05191a576edca83ffb210a90e
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/5441/1
--
To view, visit http://gerrit.cloudera.org:8080/5441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5132d3ea99a8ecd05191a576edca83ffb210a90e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make tablet copy-itest less flaky
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Make tablet_copy-itest less flaky
......................................................................
Make tablet_copy-itest less flaky
The test TestDisableTabletCopy_NoTightLoopWhenTabletDeleted sometimes
sleeps longer than 1 second when we call SleepFor() due to system load,
so we average our "per second" calculation over the time actually
elapsed.
Also bump slightly the number of log messages we tolerate due to
spurious log messages for unrelated components.
Change-Id: I5132d3ea99a8ecd05191a576edca83ffb210a90e
Reviewed-on: http://gerrit.cloudera.org:8080/5441
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5132d3ea99a8ecd05191a576edca83ffb210a90e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make tablet copy-itest less flaky
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Make tablet_copy-itest less flaky
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5132d3ea99a8ecd05191a576edca83ffb210a90e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No