You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/16 12:31:55 UTC
[GitHub] codecov-io commented on issue #1616: [Dubbo Compatible with
hessian1] Fix hessian1 serialized short, byte is converted to int
codecov-io commented on issue #1616: [Dubbo Compatible with hessian1] Fix hessian1 serialized short, byte is converted to int
URL: https://github.com/apache/incubator-dubbo/pull/1616#issuecomment-381582969
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1616?src=pr&el=h1) Report
> Merging [#1616](https://codecov.io/gh/apache/incubator-dubbo/pull/1616?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/4d885b870f9bc722650705750717ae808b397654?src=pr&el=desc) will **increase** coverage by `0.27%`.
> The diff coverage is `41.37%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/1616?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1616 +/- ##
===========================================
+ Coverage 34.52% 34.8% +0.27%
- Complexity 3685 3719 +34
===========================================
Files 621 621
Lines 30875 30892 +17
Branches 5448 5466 +18
===========================================
+ Hits 10660 10752 +92
+ Misses 18376 18287 -89
- Partials 1839 1853 +14
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1616?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...om/alibaba/com/caucho/hessian/io/HessianInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW5JbnB1dC5qYXZh) | `19.58% <41.37%> (+6.36%)` | `42 <7> (+17)` | :arrow_up: |
| [...ba/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDbGllbnQuamF2YQ==) | `74.13% <0%> (-8.63%)` | `12% <0%> (-1%)` | |
| [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `25% <0%> (-5.96%)` | `5% <0%> (-2%)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
| [...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==) | `18.61% <0%> (+0.58%)` | `60% <0%> (+2%)` | :arrow_up: |
| [...alibaba/com/caucho/hessian/io/MapDeserializer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL01hcERlc2VyaWFsaXplci5qYXZh) | `50.87% <0%> (+1.75%)` | `13% <0%> (+1%)` | :arrow_up: |
| [...ibaba/com/caucho/hessian/io/SerializerFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL1NlcmlhbGl6ZXJGYWN0b3J5LmphdmE=) | `64.76% <0%> (+3.91%)` | `51% <0%> (+5%)` | :arrow_up: |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+5%)` | `21% <0%> (+1%)` | :arrow_up: |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (+5.55%)` | `6% <0%> (+1%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1616/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1616?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1616?src=pr&el=footer). Last update [4d885b8...0c0ec6b](https://codecov.io/gh/apache/incubator-dubbo/pull/1616?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services