You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2022/03/17 20:04:05 UTC
[Impala-ASF-CR] IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18332
Change subject: IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS
......................................................................
IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS
The assertion failure happens in CentOS because the testcase
reads the virtual memory usage of the current thread from
/proc/thread-self. However, CentOS may not contain this symlink,
therefore the testcase is not able to locate the path and
then trigger the assertion.
This fix changes the path to /proc/self, which is a symlink to the
current process and contained in CentOS. Because the testcase
doesn't involve in multithreading cases, it is okay to replace
the /proc/thread-self by /proc/self to detect the memory usage.
Tests:
Passed core tests in CentOS.
Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
---
M be/src/runtime/client-cache-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/18332/1
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 15:19:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 01:13:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 20:16:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7943/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 15:19:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS
......................................................................
Patch Set 1: Code-Review+2
(4 comments)
LGTM,just some nits.
http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG@7
PS1, Line 7: fails
nit: fails -> failure
http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG@13
PS1, Line 13: then trigger the assertion.
nit: then trigger -> triggers
http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG@16
PS1, Line 16: current process and contained in CentOS. Because the testcase
nit: contained -> available
http://gerrit.cloudera.org:8080/#/c/18332/1//COMMIT_MSG@17
PS1, Line 17: doesn't involve in multithreading cases, it is okay to replace
nit: 'in multithreading cases' -> multithreading
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 00:58:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10305/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Mar 2022 01:32:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
......................................................................
IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
The assertion failure happens in CentOS because the testcase
reads the virtual memory usage of the current thread from
/proc/thread-self. However, CentOS may not contain this symlink,
therefore the testcase is not able to locate the path and
then triggers the assertion.
This fix changes the path to /proc/self, which is a symlink to the
current process and available in CentOS. Because the testcase
doesn't involve multithreading, it is okay to replace the
/proc/thread-self by /proc/self to detect the memory usage.
Tests:
Passed core tests in CentOS.
Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
---
M be/src/runtime/client-cache-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/18332/2
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion fails of ClientCacheTest.MemLeak in CentOS
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10303/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 20:24:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18332 )
Change subject: IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
......................................................................
IMPALA-11193: Fix assertion failure of ClientCacheTest.MemLeak in CentOS
The assertion failure happens in CentOS because the testcase
reads the virtual memory usage of the current thread from
/proc/thread-self. However, CentOS may not contain this symlink,
therefore the testcase is not able to locate the path and
then triggers the assertion.
This fix changes the path to /proc/self, which is a symlink to the
current process and available in CentOS. Because the testcase
doesn't involve multithreading, it is okay to replace the
/proc/thread-self by /proc/self to detect the memory usage.
Tests:
Passed core tests in CentOS.
Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Reviewed-on: http://gerrit.cloudera.org:8080/18332
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/client-cache-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18332
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I045e91aa9b7d8e1b731e3261f0f18cc932c16f43
Gerrit-Change-Number: 18332
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>