You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/07 18:44:45 UTC

[GitHub] [nifi] gschaer commented on a change in pull request #5069: NIFI-6685: Add align and distribute UI actions

gschaer commented on a change in pull request #5069:
URL: https://github.com/apache/nifi/pull/5069#discussion_r665622897



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/resources/META-INF/NOTICE
##########
@@ -1,8 +1,17 @@
 Apache NiFi
 Copyright 2014-2021 The Apache Software Foundation
+
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
 
+******************
+Apache Software License v2
+******************
+The following binary components are provided under the Apache Software License v2
+  (ASLv2) Carbon Design System Icons
+    The following NOTICE information applies:
+      Copyright 2015 IBM Corp.
+

Review comment:
       Good question. I took the icons I needed from the Carbon Design System Icons and I integrated them into Flowfont using Fontello. Fontello was used 5 years ago to generate Flowfont: https://fontello.com/
   
   So technically, I used some components from Carbon Design System Icons. As I understand (but I'm not a lawyer), I should add the license of the Carbon Design System Icons.
   
   If you look at the main license file, we reference the Fontello license.  https://github.com/apache/nifi/blob/7fe8858d22f580ad9dcd96ebafb59dbe5e73f5cb/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/resources/META-INF/LICENSE#L681-L701
   
   As we reference the tool used to generate the font, I think we should reference the license of the icons used in the app. 
   
   Or we need to think about removing the reference to the Fontello license.
   
   What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org