You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/09 15:33:26 UTC

[GitHub] [incubator-tvm] tqchen commented on pull request #5236: [WIP][TVM][.NET] Introduce TVM.NET project

tqchen commented on pull request #5236:
URL: https://github.com/apache/incubator-tvm/pull/5236#issuecomment-626193368


   Language bindings are important features that we want to hold the highest standard as possible. So we do expect for longer review time, as well as more polishment.  
   
   In a nutshell, what we want is not "an implement" of the feature we want. But to implement the feature in the best possible way so that it can be maintained, reused and developed in the future with minimum techinical debt.
   
   I am not expert in csharp, but by quickly look at the package, I do think it needs mroe careful works to meet the standard of our current language binding. Here are some high level comments:
   
   - Structure:  think about a common structure. Take a look at existing projects for example
      - e.g. mldotnet https://github.com/dotnet/machinelearning/tree/master/src
      - A possible structure for tvm could be `root/donet/src/`
      - I do not see any reason why we need a separate subfolder for each .cs file
      -  We should not include binaries: e.g. add_one.dll into the code repo.
      - There are additional files (Class1) which seems to be created from the the getting started guide but was not used here.
   - Naming: I would try to follow other language binding naming convention as much as possible, in particular, the web, java and golang one are good references. e.g. UnmanagedRuntime
   - Layers of abstractions: there are see many indirections and manager class(from manged to unmanaged), many of them seems to be un-necessary.  By convention, the FFI layer is un-managed, and all the wrappers on top are managed. Again, jvm runtime would be a good example to follow.
   - Given that a language binding needs to be maintained and reviewed separately, we should get someone who is able to collaborate and review the codebase. Since reviewing is as time consuming as implementing the feature, so please try to polish as much as you can.
      - Ideally, we want to have as many vets on the API design as much as possible.
   
   Given the current state, you could try release the package elsewhere and improve it before mainlining it back. Please also feel free to refer to other language bindings for reference.
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org