You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2023/10/25 10:49:04 UTC
[PR] GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests [arrow]
AlenkaF opened a new pull request, #38455:
URL: https://github.com/apache/arrow/pull/38455
### Rationale for this change
Appveyor CI is failing https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/48347810. It seems the reason for the test failures is a change in the `type_name` (from `"py::fsspec+s3"` to `"py::fsspec+('s3', 's3a')"`) and due to it tests are not being skipped.
### What changes are included in this PR?
Update the check for `type_name` in case of `PyFileSystem(FSSpecHandler(s3fs.S3FileSystem()))`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38455:
URL: https://github.com/apache/arrow/pull/38455#issuecomment-1782565364
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3f4aeab22ab7e37ae86525951d0abd74fc5bc684.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/18114266796) has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38455:
URL: https://github.com/apache/arrow/pull/38455#issuecomment-1779682194
@github-actions crossbow submit -g conda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38455:
URL: https://github.com/apache/arrow/pull/38455#issuecomment-1779258770
Revision: 3a53d1133e91ac6e543a7a3175689481b45f21f1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a83bce7a72](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a83bce7a72)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/6640986360/job/18042500968)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/6640984295/job/18042494173)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/6640986885/job/18042503165)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/6640986078/job/18042500006)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6640987442/job/18042504886)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/6640984499/job/18042494447)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6640984915/job/18042496129)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/6640983120/job/18042490384)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/6640981355/job/18042484900)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6640987765/job/18042505943)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6640985680/job/18042498225)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/6640982150/job/18042487223)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/6640979820/job/18042479998)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/6640988175/job/18042507294)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/6640980417/job/18042482050)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/6640979448/job/18042478939)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6640980034/job/18042480720)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/6640983874/job/18042492708)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/6640982540/job/18042488435)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/6640982806/job/18042489317)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/6640983704/job/18042492087)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/18042485632)|
|test-fedora-35-python-3|[](https://github.com/ursacomputing/crossbow/runs/18042488221)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/18042500071)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/6640987117/job/18042503857)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38455:
URL: https://github.com/apache/arrow/pull/38455#issuecomment-1779253351
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38455:
URL: https://github.com/apache/arrow/pull/38455#issuecomment-1779061539
AppVeyor is passing but other Python builds are still using the old version of `s3fs` (`2023.9.2`). Will change the pin in `conda_env_python.txt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38455:
URL: https://github.com/apache/arrow/pull/38455#issuecomment-1779687012
Revision: 3a53d1133e91ac6e543a7a3175689481b45f21f1
Submitted crossbow builds: [ursacomputing/crossbow @ actions-716f9fca2a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-716f9fca2a)
|Task|Status|
|----|------|
|conda-clean|[](https://github.com/ursacomputing/crossbow/runs/18051079904)|
|conda-linux-aarch64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/18051074619)|
|conda-linux-aarch64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/18051069384)|
|conda-linux-aarch64-cpu-r43|[](https://github.com/ursacomputing/crossbow/runs/18051066708)|
|conda-linux-aarch64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/18051067799)|
|conda-linux-ppc64le-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/18051068221)|
|conda-linux-ppc64le-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/18051075922)|
|conda-linux-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/18051068895)|
|conda-linux-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/18051066010)|
|conda-linux-x64-cpu-r43|[](https://github.com/ursacomputing/crossbow/runs/18051065233)|
|conda-linux-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/18051076862)|
|conda-osx-arm64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/18051071466)|
|conda-osx-arm64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/18051079452)|
|conda-osx-arm64-cpu-r43|[](https://github.com/ursacomputing/crossbow/runs/18051072007)|
|conda-osx-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/18051077787)|
|conda-osx-x64-cpu-r42|[](https://github.com/ursacomputing/crossbow/runs/18051070315)|
|conda-osx-x64-cpu-r43|[](https://github.com/ursacomputing/crossbow/runs/18051081017)|
|conda-win-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/18051072779)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/18051067347)|
|conda-win-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/18051076354)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38431: [Python][CI] Update fs.type_name checks for s3fs tests [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #38455:
URL: https://github.com/apache/arrow/pull/38455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org