You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2022/06/29 09:44:25 UTC

[GitHub] [sling-org-apache-sling-committer-cli] raducotescu opened a new pull request, #14: SLING-11426 - The apache/sling-cli Docker image cannot be built on M1 processors

raducotescu opened a new pull request, #14:
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/14

   * updated the docker-maven-plugin to latest (0.40.1)
   * switched to JDK 17 from Azul (this also works fine on M1 in comparison with the images that provide JDK 11), since it offers all architectures we need
   
   This PR reverts the switch to Temurin from #12, since Temurin doesn't offer an arm64v8 image unless one uses the specific architecture repository. This would lead to profiles that would use different images based on host architecture.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-committer-cli] raducotescu commented on a diff in pull request #14: SLING-11426 - The apache/sling-cli Docker image cannot be built on M1 processors

Posted by GitBox <gi...@apache.org>.
raducotescu commented on code in PR #14:
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/14#discussion_r911374155


##########
Dockerfile:
##########
@@ -9,7 +9,8 @@
 # either express or implied. See the License for the specific language governing permissions
 # and limitations under the License.
 # ----------------------------------------------------------------------------------------
-FROM eclipse-temurin:11-alpine as builder
+FROM azul/zulu-openjdk-alpine:17 as builder
+RUN apk add --no-cache binutils

Review Comment:
   `--strip-debug` requires `objcopy` starting with JDK 13 - https://github.com/docker-library/openjdk/issues/351.
   
   We can either add `binutils` in this builder layer and continue using `--strip-debug`, or switch to `--strip-java-debug-attributes`, which nowadays does what `--strip-debug` used to do in JDK 11. See https://bugs.openjdk.org/browse/JDK-8219207 for more details.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-committer-cli] raducotescu merged pull request #14: SLING-11426 - The apache/sling-cli Docker image cannot be built on M1 processors

Posted by GitBox <gi...@apache.org>.
raducotescu merged PR #14:
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-committer-cli] sonarcloud[bot] commented on pull request #14: SLING-11426 - The apache/sling-cli Docker image cannot be built on M1 processors

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #14:
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/14#issuecomment-1169773641

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&metric=coverage&view=list) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-committer-cli&pullRequest=14&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-committer-cli] raducotescu commented on a diff in pull request #14: SLING-11426 - The apache/sling-cli Docker image cannot be built on M1 processors

Posted by GitBox <gi...@apache.org>.
raducotescu commented on code in PR #14:
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/14#discussion_r911374155


##########
Dockerfile:
##########
@@ -9,7 +9,8 @@
 # either express or implied. See the License for the specific language governing permissions
 # and limitations under the License.
 # ----------------------------------------------------------------------------------------
-FROM eclipse-temurin:11-alpine as builder
+FROM azul/zulu-openjdk-alpine:17 as builder
+RUN apk add --no-cache binutils

Review Comment:
   `--strip-debug` requires `objcopy` starting with JDK 13 - https://github.com/docker-library/openjdk/issues/351.
   
   We can either add `binutils` in this builder layer and continue using `--strip-debug`, or switch to `--strip-java-debug-attributes`, which nowadays does what `--strip-debug` used to do in JDK 11. See https://bugs.openjdk.org/browse/JDK-8219207 for more details.
   
   I'll wait for your ack before merging. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-committer-cli] rombert commented on a diff in pull request #14: SLING-11426 - The apache/sling-cli Docker image cannot be built on M1 processors

Posted by GitBox <gi...@apache.org>.
rombert commented on code in PR #14:
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/14#discussion_r911701962


##########
Dockerfile:
##########
@@ -9,7 +9,8 @@
 # either express or implied. See the License for the specific language governing permissions
 # and limitations under the License.
 # ----------------------------------------------------------------------------------------
-FROM eclipse-temurin:11-alpine as builder
+FROM azul/zulu-openjdk-alpine:17 as builder
+RUN apk add --no-cache binutils

Review Comment:
   Feel free to pick whatever you think is best, I was just curious :-) Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-committer-cli] rombert commented on a diff in pull request #14: SLING-11426 - The apache/sling-cli Docker image cannot be built on M1 processors

Posted by GitBox <gi...@apache.org>.
rombert commented on code in PR #14:
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/14#discussion_r909576361


##########
Dockerfile:
##########
@@ -9,7 +9,8 @@
 # either express or implied. See the License for the specific language governing permissions
 # and limitations under the License.
 # ----------------------------------------------------------------------------------------
-FROM eclipse-temurin:11-alpine as builder
+FROM azul/zulu-openjdk-alpine:17 as builder
+RUN apk add --no-cache binutils

Review Comment:
   Out of curiosity, why is `binutils` needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org