You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/31 03:17:21 UTC
[GitHub] [tvm] sxjscience opened a new issue #7186: [Frontend][MXNet] Importer Missing Operators
sxjscience opened a new issue #7186:
URL: https://github.com/apache/tvm/issues/7186
# Feature Request
Recently, TVM has supported the incoming MXNet 2.0 frontend via a series of PRs: https://github.com/apache/incubator-tvm/pull/6054, https://github.com/apache/incubator-tvm/pull/6699. This enables the new GluonNLP 1.0, which has been upgraded from MXNet 1.x to MXNet 2.0 to convert to TVM graph (as added in https://github.com/dmlc/gluon-nlp/pull/1390).
However, not all operators in MXNet support conversion to TVM. The following is the list of operators that need to be supported.
- [ ] _npi_subtract_scalar [BART model](https://github.com/dmlc/gluon-nlp/blob/master/src/gluonnlp/models/bart.py)
- [ ] _npi_stack, [BART model](https://github.com/dmlc/gluon-nlp/blob/master/src/gluonnlp/models/bart.py)
- [ ] _npi_advanced_indexing_multiple, [BART model](https://github.com/dmlc/gluon-nlp/blob/master/src/gluonnlp/models/bart.py). This is triggered when we call `a[idx1, idx2]`. Also see the [MXNet-side implementation](https://github.com/apache/incubator-mxnet/blob/6bbd53107aa16fc41e8d462cf5dc46fb70d592df/src/operator/numpy/np_indexing_op.cc#L479-L491).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sxjscience commented on issue #7186: [Frontend][MXNet] Importer Missing Operators
Posted by GitBox <gi...@apache.org>.
sxjscience commented on issue #7186:
URL: https://github.com/apache/tvm/issues/7186#issuecomment-757379032
Also, there is another issue that I observed in GluonNLP: https://github.com/dmlc/gluon-nlp/issues/1425 . The initial investigation suggests it's related to mixed-dtype support in the MXNet --> TVM converter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sxjscience commented on issue #7186: [Frontend][MXNet] Importer Missing Operators
Posted by GitBox <gi...@apache.org>.
sxjscience commented on issue #7186:
URL: https://github.com/apache/tvm/issues/7186#issuecomment-757379032
Also, there is another issue that I observed in GluonNLP: https://github.com/dmlc/gluon-nlp/issues/1425 . The initial investigation suggests it's related to mixed-dtype support in the MXNet --> TVM converter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] insop commented on issue #7186: [Frontend][MXNet] Importer Missing Operators
Posted by GitBox <gi...@apache.org>.
insop commented on issue #7186:
URL: https://github.com/apache/tvm/issues/7186#issuecomment-757390785
> For `_npi_advanced_indexing_multiple ` is at [#7230 (review)](https://github.com/apache/tvm/pull/7230#pullrequestreview-564031534), PTAL.
@sxjscience
Any help on the above PR will be appreciated.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] insop commented on issue #7186: [Frontend][MXNet] Importer Missing Operators
Posted by GitBox <gi...@apache.org>.
insop commented on issue #7186:
URL: https://github.com/apache/tvm/issues/7186#issuecomment-757390785
> For `_npi_advanced_indexing_multiple ` is at [#7230 (review)](https://github.com/apache/tvm/pull/7230#pullrequestreview-564031534), PTAL.
@sxjscience
Any help on the above PR will be appreciated.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] insop commented on issue #7186: [Frontend][MXNet] Importer Missing Operators
Posted by GitBox <gi...@apache.org>.
insop commented on issue #7186:
URL: https://github.com/apache/tvm/issues/7186#issuecomment-753571157
For `_npi_subtract_scalar` BART model: https://github.com/apache/tvm/pull/7191 is submitted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] insop commented on issue #7186: [Frontend][MXNet] Importer Missing Operators
Posted by GitBox <gi...@apache.org>.
insop commented on issue #7186:
URL: https://github.com/apache/tvm/issues/7186#issuecomment-754387174
For `_npi_stack ` : https://github.com/apache/tvm/pull/7209 is submitted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] sxjscience commented on issue #7186: [Frontend][MXNet] Importer Missing Operators
Posted by GitBox <gi...@apache.org>.
sxjscience commented on issue #7186:
URL: https://github.com/apache/tvm/issues/7186#issuecomment-752828553
@junrushao1994 I created this new issue. Also, I just figured out that I cannot attach the "help wanted" label so would you help with that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] insop commented on issue #7186: [Frontend][MXNet] Importer Missing Operators
Posted by GitBox <gi...@apache.org>.
insop commented on issue #7186:
URL: https://github.com/apache/tvm/issues/7186#issuecomment-756578686
For `_npi_advanced_indexing_multiple ` is at https://github.com/apache/tvm/pull/7230#pullrequestreview-564031534, PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org