[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #952: [HUDI-301] fix path error when updating a non-partition MOR table

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #952: [HUDI-301] fix path error when updating a non-partition MOR table
URL: https://github.com/apache/incubator-hudi/pull/952#discussion_r334018746
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
 ##########
 @@ -140,7 +140,8 @@ private void init(HoodieRecord record) {
         throw new HoodieUpsertException("Failed to initialize HoodieAppendHandle for FileId: " + fileId + " on commit "
             + instantTime + " on HDFS path " + hoodieTable.getMetaClient().getBasePath() + partitionPath, e);
       }
-      Path path = new Path(partitionPath, writer.getLogFile().getFileName());
+      Path path = partitionPath.length() == 0 ? new Path(writer.getLogFile().getFileName())
 
 Review comment:
   +1 Good catch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services