[GitHub] sanha commented on a change in pull request #33: [NEMO-111] Remove ExecutionProperty.Key

[GitBox <gi...@apache.org>]

sanha commented on a change in pull request #33: [NEMO-111] Remove ExecutionProperty.Key
URL: https://github.com/apache/incubator-nemo/pull/33#discussion_r195634231
 
 

 ##########
 File path: compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/annotating/ScheduleGroupPass.java
 ##########
 @@ -55,20 +56,21 @@ public ScheduleGroupPass() {
   @Override
   public DAG<IRVertex, IREdge> apply(final DAG<IRVertex, IREdge> dag) {
     // We assume that the input dag is tagged with stage ids.
-    if (dag.getVertices().stream().anyMatch(irVertex -> irVertex.getProperty(StageId) == null)) {
+    if (!dag.getVertices().stream()
+        .anyMatch(irVertex -> irVertex.getPropertyValue(StageIdProperty.class).isPresent())) {
 
 Review comment:
   Doesn't this modification change the original meaning?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services