You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 10:00:44 UTC
[GitHub] [flink] wuchong opened a new pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
wuchong opened a new pull request #12221:
URL: https://github.com/apache/flink/pull/12221
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
The legacy JDBC and HBase table source support projection push down. In order to make the user experience consistent. We should align the behavior and add tests. Otherwise, users may be superised when upgrade to new connector but the performance is regressive.
## Brief change log
- improve the testing implementation of projection push down (merge `TestProjectableValuesTableFactory` into `TestValuesTableFactory`).
- Add `TableSchemaUtil#projectSchema` to let connector can easily get the projected schema.
- Make the new jdbc and hbase source have the ability to push projections
## Verifying this change
- Added plan tests
- The projection pushdown integeration tests have already existed.
## Verifying this change
This change added a test which transforms a nested data type.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 129d85d4bcc2b032ff5be1999a8a0277f31a2848 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #12221:
URL: https://github.com/apache/flink/pull/12221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
}, {
"hash" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829",
"triggerID" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd621a07015e49f48360dd5f60209c0ef0cdaa32 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796)
* c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630614848
thanks for the update, LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 129d85d4bcc2b032ff5be1999a8a0277f31a2848 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726)
* bd621a07015e49f48360dd5f60209c0ef0cdaa32 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
}, {
"hash" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829",
"triggerID" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"triggerType" : "PUSH"
}, {
"hash" : "d738c10c4af67bcd74b10b93ad796ff7d0a92a11",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1869",
"triggerID" : "d738c10c4af67bcd74b10b93ad796ff7d0a92a11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829)
* d738c10c4af67bcd74b10b93ad796ff7d0a92a11 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630563803
Rebased to resolve compile problem and updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
}, {
"hash" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd621a07015e49f48360dd5f60209c0ef0cdaa32 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796)
* c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd621a07015e49f48360dd5f60209c0ef0cdaa32 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
}, {
"hash" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829",
"triggerID" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"triggerType" : "PUSH"
}, {
"hash" : "d738c10c4af67bcd74b10b93ad796ff7d0a92a11",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d738c10c4af67bcd74b10b93ad796ff7d0a92a11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829)
* d738c10c4af67bcd74b10b93ad796ff7d0a92a11 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630109415
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d738c10c4af67bcd74b10b93ad796ff7d0a92a11 (Fri Oct 16 10:51:17 UTC 2020)
**Warnings:**
* **2 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
}, {
"hash" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829",
"triggerID" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 129d85d4bcc2b032ff5be1999a8a0277f31a2848 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a change in pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #12221:
URL: https://github.com/apache/flink/pull/12221#discussion_r426996670
##########
File path: flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseTablePlanTest.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.hbase;
+
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.planner.utils.StreamTableTestUtil;
+import org.apache.flink.table.planner.utils.TableTestBase;
+
+import org.junit.Test;
+
+/**
+ * Plan tests for HBase connector, for example, testing projection push down.
+ */
+public class HBaseTablePlanTest extends TableTestBase {
+
+ private final StreamTableTestUtil util = streamTestUtil(new TableConfig());
+
+ @Test
+ public void testProjectionPushDown() {
Review comment:
also add some tests for `validatePrimaryKey` case ?
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcLookupTableITCase.java
##########
@@ -146,13 +150,17 @@ public void clearOutputTable() throws Exception {
public void test() throws Exception {
Review comment:
give a more meaningful name here ?
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TableSchemaUtils.java
##########
@@ -61,6 +63,23 @@ public static TableSchema getPhysicalSchema(TableSchema tableSchema) {
return builder.build();
}
+ /**
+ * Creates a new {@link TableSchema} with the projected fields from another {@link TableSchema}.
+ *
+ * @see org.apache.flink.table.connector.source.abilities.SupportsProjectionPushDown
+ */
+ public static TableSchema projectSchema(TableSchema tableSchema, int[][] projectedFields) {
Review comment:
please add some test for this method
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcLookupTableITCase.java
##########
@@ -46,24 +46,28 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
+import java.util.Collections;
+import java.util.Iterator;
import java.util.List;
+import java.util.stream.Collectors;
import static org.apache.flink.connector.jdbc.JdbcTestFixture.DERBY_EBOOKSHOP_DB;
import static org.apache.flink.table.api.Expressions.$;
+import static org.junit.Assert.assertEquals;
/**
- * IT case for {@link JdbcLookupFunction}.
+ * IT case for lookup source of JDBC connector.
*/
@RunWith(Parameterized.class)
-public class JdbcLookupFunctionITCase extends AbstractTestBase {
+public class JdbcLookupTableITCase extends AbstractTestBase {
Review comment:
add some cases for projection
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java
##########
@@ -126,9 +128,20 @@ public ChangelogMode getChangelogMode() {
return ChangelogMode.insertOnly();
}
+ @Override
+ public boolean supportsNestedProjection() {
+ // JDBC doesn't support nested projection
+ return false;
+ }
+
+ @Override
+ public void applyProjection(int[][] projectedFields) {
+ this.physicalSchema = TableSchemaUtils.projectSchema(physicalSchema, projectedFields);
Review comment:
`selectFields` need to be updated ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630109415
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 129d85d4bcc2b032ff5be1999a8a0277f31a2848 (Mon May 18 11:04:37 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12221:
URL: https://github.com/apache/flink/pull/12221#discussion_r427012826
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcLookupTableITCase.java
##########
@@ -46,24 +46,28 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
+import java.util.Collections;
+import java.util.Iterator;
import java.util.List;
+import java.util.stream.Collectors;
import static org.apache.flink.connector.jdbc.JdbcTestFixture.DERBY_EBOOKSHOP_DB;
import static org.apache.flink.table.api.Expressions.$;
+import static org.junit.Assert.assertEquals;
/**
- * IT case for {@link JdbcLookupFunction}.
+ * IT case for lookup source of JDBC connector.
*/
@RunWith(Parameterized.class)
-public class JdbcLookupFunctionITCase extends AbstractTestBase {
+public class JdbcLookupTableITCase extends AbstractTestBase {
Review comment:
We don't support projection for lookup source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12221:
URL: https://github.com/apache/flink/pull/12221#discussion_r427009783
##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java
##########
@@ -126,9 +128,20 @@ public ChangelogMode getChangelogMode() {
return ChangelogMode.insertOnly();
}
+ @Override
+ public boolean supportsNestedProjection() {
+ // JDBC doesn't support nested projection
+ return false;
+ }
+
+ @Override
+ public void applyProjection(int[][] projectedFields) {
+ this.physicalSchema = TableSchemaUtils.projectSchema(physicalSchema, projectedFields);
Review comment:
Removed `selectFields` because we don't need it. The `physicalSchema` is the selected schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 129d85d4bcc2b032ff5be1999a8a0277f31a2848 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726)
* bd621a07015e49f48360dd5f60209c0ef0cdaa32 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 129d85d4bcc2b032ff5be1999a8a0277f31a2848 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12221: [FLINK-17797][FLINK-17798][hbase][jdbc] Align the behavior between the new and legacy HBase/JDBC table source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12221:
URL: https://github.com/apache/flink/pull/12221#issuecomment-630123655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1726",
"triggerID" : "129d85d4bcc2b032ff5be1999a8a0277f31a2848",
"triggerType" : "PUSH"
}, {
"hash" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1796",
"triggerID" : "bd621a07015e49f48360dd5f60209c0ef0cdaa32",
"triggerType" : "PUSH"
}, {
"hash" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1829",
"triggerID" : "c7de5861d4b32b0bb0629a80a28aa28d5aef7f9f",
"triggerType" : "PUSH"
}, {
"hash" : "d738c10c4af67bcd74b10b93ad796ff7d0a92a11",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1869",
"triggerID" : "d738c10c4af67bcd74b10b93ad796ff7d0a92a11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d738c10c4af67bcd74b10b93ad796ff7d0a92a11 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org