You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by Karl Heinz Marbaise <kh...@gmx.de> on 2016/12/18 15:06:22 UTC

[LANG] LANG-1301

Hi,

i would like to apply the attached patch to the code base?

any objections to that? Or anything I need to pay attention to?

Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [LANG] LANG-1301

Posted by Karl Heinz Marbaise <kh...@gmx.de>.

Hi Pascal,

On 18/12/16 16:11, Pascal Schumacher wrote:
> Hi Karl Heinz,
>
> have already applied your patch:
> https://github.com/apache/commons-lang/commit/6cfee3d0e501f781ac5b25aed0b7278ed6ed9543
>
>
> Sorry I did not consider the possibility that you would like to do it
> yourself. :(

No problem.

Kind regards
Karl Heinz Marbaise
>
> Kind regards,
> Pascal
>
> Am 18.12.2016 um 16:06 schrieb Karl Heinz Marbaise:
>> Hi,
>>
>> i would like to apply the attached patch to the code base?
>>
>> any objections to that? Or anything I need to pay attention to?
>>
>> Kind regards
>> Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [LANG] LANG-1301

Posted by Pascal Schumacher <pa...@gmx.net>.

Hi Karl Heinz,

sorry I would have referenced LANG-1301 in the commit message, but it 
did not exist (or at least I was not aware of its existence) when I 
committed. I took you patch from 
https://issues.apache.org/jira/browse/RAT-225

I have just closed LANG-1301 and added it to changes.xml.

Kind regards,
Pascal

Am 18.12.2016 um 16:19 schrieb Karl Heinz Marbaise:
> Hi Pascal,
>
> It looks like you haven't given the references to LANG-1301 in the 
> commit message...;-(...nor you have closed the issue LANG-1301...
>
> Kind regards
> Karl Heinz Marbaise...
> On 18/12/16 16:11, Pascal Schumacher wrote:
>> Hi Karl Heinz,
>>
>> have already applied your patch:
>> https://github.com/apache/commons-lang/commit/6cfee3d0e501f781ac5b25aed0b7278ed6ed9543 
>>
>>
>>
>> Sorry I did not consider the possibility that you would like to do it
>> yourself. :(
>>
>> Kind regards,
>> Pascal
>>
>> Am 18.12.2016 um 16:06 schrieb Karl Heinz Marbaise:
>>> Hi,
>>>
>>> i would like to apply the attached patch to the code base?
>>>
>>> any objections to that? Or anything I need to pay attention to?
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [LANG] LANG-1301

Posted by Karl Heinz Marbaise <kh...@gmx.de>.

Hi Pascal,

It looks like you haven't given the references to LANG-1301 in the 
commit message...;-(...nor you have closed the issue LANG-1301...

Kind regards
Karl Heinz Marbaise...
On 18/12/16 16:11, Pascal Schumacher wrote:
> Hi Karl Heinz,
>
> have already applied your patch:
> https://github.com/apache/commons-lang/commit/6cfee3d0e501f781ac5b25aed0b7278ed6ed9543
>
>
> Sorry I did not consider the possibility that you would like to do it
> yourself. :(
>
> Kind regards,
> Pascal
>
> Am 18.12.2016 um 16:06 schrieb Karl Heinz Marbaise:
>> Hi,
>>
>> i would like to apply the attached patch to the code base?
>>
>> any objections to that? Or anything I need to pay attention to?
>>
>> Kind regards
>> Karl Heinz Marbaise
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [LANG] LANG-1301

Posted by Pascal Schumacher <pa...@gmx.net>.

Hi Karl Heinz,

have already applied your patch: 
https://github.com/apache/commons-lang/commit/6cfee3d0e501f781ac5b25aed0b7278ed6ed9543

Sorry I did not consider the possibility that you would like to do it 
yourself. :(

Kind regards,
Pascal

Am 18.12.2016 um 16:06 schrieb Karl Heinz Marbaise:
> Hi,
>
> i would like to apply the attached patch to the code base?
>
> any objections to that? Or anything I need to pay attention to?
>
> Kind regards
> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org