[GitHub] [iceberg] rdblue commented on a diff in pull request #5303: Add a BoundBooleanExpressionVisitor for visiting bound expressions

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5303:
URL: https://github.com/apache/iceberg/pull/5303#discussion_r954077446


##########
python/pyiceberg/expressions/base.py:
##########
@@ -672,3 +683,55 @@ def visit_unbound_predicate(self, predicate) -> BooleanExpression:
 
     def visit_bound_predicate(self, predicate) -> BooleanExpression:
         raise TypeError(f"Found already bound predicate: {predicate}")
+
+
+class BoundBooleanExpressionVisitor(BooleanExpressionVisitor[T], ABC):
+    @abstractmethod
+    def visit_in(self, ref: BoundReference[T], literals: set[Literal[Any]]) -> T:

Review Comment:
   If we update this to Term then we won't need to implement `handle_non_reference` because visitors will be built to handle non-references.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org