You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by amillerchip <gi...@git.apache.org> on 2016/02/02 09:34:18 UTC
[GitHub] thrift pull request: THRIFT-3595 Perl: Unify implementation of set...
GitHub user amillerchip opened a pull request:
https://github.com/apache/thrift/pull/831
THRIFT-3595 Perl: Unify implementation of set as a hashref
https://issues.apache.org/jira/browse/THRIFT-3595
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amillerchip/thrift THRIFT-3595
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #831
----
commit 5f0f0cf57ad8c38b0b2206813a600d700aa181ac
Author: Adam Millerchip <ad...@millerchip.net>
Date: 2016-02-02T08:27:03Z
THRIFT-3595 Perl: Unify implementation of set as a hashref
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #831: THRIFT-3595 Perl: Unify implementation of set as a...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/831#discussion_r146873988
--- Diff: test/perl/TestClient.pl ---
@@ -250,16 +250,16 @@ sub usage {
#
# SET TEST
#
-my $setout = [];
+my $setout = {};
for (my $i = -2; $i < 3; ++$i) {
- push(@$setout, $i);
+ $setout->{$i} = 1;
--- End diff --
Do you have a follow-up to this?
---
[GitHub] thrift issue #831: THRIFT-3595 Perl: Unify implementation of set as a hashre...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/831
I have an open backlog item to use Set::Scalar for perl sets. https://issues.apache.org/jira/browse/THRIFT-3190
---
[GitHub] thrift pull request: THRIFT-3595 Perl: Unify implementation of set...
Posted by amillerchip <gi...@git.apache.org>.
Github user amillerchip commented on a diff in the pull request:
https://github.com/apache/thrift/pull/831#discussion_r52270450
--- Diff: test/perl/TestClient.pl ---
@@ -250,16 +250,16 @@ sub usage {
#
# SET TEST
#
-my $setout = [];
+my $setout = {};
for (my $i = -2; $i < 3; ++$i) {
- push(@$setout, $i);
+ $setout->{$i} = 1;
--- End diff --
It's just been pointed out to me this this will not work if `$i` is an object, because it will get serialised to its string representation when used as the hash key like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---