You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/16 17:51:09 UTC

[GitHub] [spark] xinrong-meng commented on a diff in pull request #37367: [SPARK-39941][PYTHON][PS] window and min_periods should be integer in rolling func

xinrong-meng commented on code in PR #37367:
URL: https://github.com/apache/spark/pull/37367#discussion_r947083497


##########
python/pyspark/pandas/window.py:
##########
@@ -144,10 +144,15 @@ def __init__(
         window: int,
         min_periods: Optional[int] = None,
     ):
+        if type(window) is not int:
+            raise ValueError("window must be an integer")

Review Comment:
   Thanks @itholic.
   
   If so, shall we check negative `window` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org