You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "oneby-wang (via GitHub)" <gi...@apache.org> on 2025/09/19 06:26:45 UTC

[PR] [fix][admin] set local policies overwrites "number of bundles" passed during namespace creation [pulsar]

oneby-wang opened a new pull request, #24762:
URL: https://github.com/apache/pulsar/pull/24762

   <!-- Either this PR fixes an issue, -->
   
   Fixes [#xyz]([[Bug] set-bookie-affinity-group overwrites "number of bundles" passed during namespace creation · Is](https://github.com/apache/pulsar/issues/23897))
   
   ### Motivation
   
   <!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
   
   Set local policies will overwrite "number of bundles" passed during namespace creation. If we don't call any get namespace policies operation, local policies will not be created, so it will be overwritten.
   [pulsar/pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java at 88](https://github.com/apache/pulsar/blob/8879b3ba9daa6de9b8b78bbce89bab68cc37cf0b/pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java#L164-L182)
   
   The following steps can reproduce the problem.
   1. pulsar-admin namespaces create t/n --bundles 10
   2. pulsar-admin namespaces set-bookie-affinity-group --primary-group temp t/n
   3. pulsar-admin namespaces bundles t/n
   
   But the following step will not reproduce the problem.
   1. pulsar-admin namespaces create t/n --bundles 10
   2. pulsar-admin namespaces bundles t/n
   3. pulsar-admin namespaces set-bookie-affinity-group --primary-group temp t/n
   4. pulsar-admin namespaces bundles t/n
   
   ### Modifications
   
   <!-- Describe the modifications you've done. -->
   
   If  local policies is not present, first try to use namespace policies bundle data, then fallback to `config().getDefaultNumberOfNamespaceBundles()`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: 
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org