You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vy...@gmail.com> on 2015/03/24 17:18:28 UTC

Review Request 32442: Patch for SQOOP-1635

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32442/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1635
    https://issues.apache.org/jira/browse/SQOOP-1635


Repository: sqoop-sqoop2


Description
-------

depends on SQOOP-2113, else it will fail to compile.


Diffs
-----

  connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java 0d9a1cf 
  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ba8fcf3 
  shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 1a5f354 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 02e8c8c 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java c0c47e1 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java d15d812 
  shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java 9438441 
  shell/src/main/resources/shell-resource.properties 271ee90 

Diff: https://reviews.apache.org/r/32442/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 32442: Patch for SQOOP-1635

Posted by Veena Basavaraj <vy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32442/#review77588
-----------------------------------------------------------



connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java
<https://reviews.apache.org/r/32442/#comment125710>

    this is an unintended change



shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
<https://reviews.apache.org/r/32442/#comment125709>

    this ordering will be of course fixed.


- Veena Basavaraj


On March 24, 2015, 9:18 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32442/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 9:18 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1635
>     https://issues.apache.org/jira/browse/SQOOP-1635
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> depends on SQOOP-2113, else it will fail to compile.
> 
> 
> Diffs
> -----
> 
>   connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestJSONIntermediateDataFormat.java 0d9a1cf 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ba8fcf3 
>   shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 1a5f354 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 02e8c8c 
>   shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java c0c47e1 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java d15d812 
>   shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java 9438441 
>   shell/src/main/resources/shell-resource.properties 271ee90 
> 
> Diff: https://reviews.apache.org/r/32442/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 32442: Patch for SQOOP-1635

Posted by Veena Basavaraj <vy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32442/
-----------------------------------------------------------

(Updated March 24, 2015, 8:38 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1635
    https://issues.apache.org/jira/browse/SQOOP-1635


Repository: sqoop-sqoop2


Description
-------

depends on SQOOP-2113, else it will fail to compile.


Diffs (updated)
-----

  shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java ba8fcf3 
  shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java 1a5f354 
  shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 02e8c8c 
  shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java c0c47e1 
  shell/src/main/java/org/apache/sqoop/shell/core/Constants.java d15d812 
  shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java 9438441 
  shell/src/main/resources/shell-resource.properties 271ee90 

Diff: https://reviews.apache.org/r/32442/diff/


Testing
-------


Thanks,

Veena Basavaraj