You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Peter Vary (JIRA)" <ji...@apache.org> on 2019/01/03 09:59:00 UTC

[jira] [Commented] (HIVE-21071) Improve getInputSummary

    [ https://issues.apache.org/jira/browse/HIVE-21071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732831#comment-16732831 ] 

Peter Vary commented on HIVE-21071:
-----------------------------------

[~belugabehr]: Could you please create a review board for this change. Also please remove the formatting only changes - they make it hard to review the relevant part of the change.

Thanks a lot!

Peter

> Improve getInputSummary
> -----------------------
>
>                 Key: HIVE-21071
>                 URL: https://issues.apache.org/jira/browse/HIVE-21071
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>    Affects Versions: 3.0.0, 4.0.0, 3.1.1
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Major
>         Attachments: HIVE-21071.1.patch
>
>
> There is a global lock in the {{getInptSummary}} code, so it is important that it be fast.  The current implementation has quite a bit of overhead that can be re-engineered.
> For example, the current implementation keeps a map of File Path to ContentSummary object.  This map is populated by several threads concurrently. The method then loops through the map, in a single thread, at the end to add up all of the ContentSummary objects and ignores the paths.  The code can be be re-engineered to not use a map, or a collection at all, to store the results and instead just keep a running tally.  By keeping a tally, there is no {{O\(n)}} operation at the end to perform the addition.
> There are other things can be improved.  The method returns an object which is never used anywhere, so change method to void return type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)