You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/18 09:15:11 UTC

[GitHub] [hudi] yui2010 commented on pull request #1748: [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…

yui2010 commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-645891968


   1. in TimestampBasedKeyGenerator#getKey method, generate a HoodieKey will create  a new SimpleDateFormat Object,the dateformat object can be reused as Class variable
   2. SimpleDateFormat is not thread safe,there is always potential thread safe problem


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org