You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by xinzweb <gi...@git.apache.org> on 2016/01/08 01:54:15 UTC
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
GitHub user xinzweb opened a pull request:
https://github.com/apache/incubator-hawq/pull/252
Fix 'hawq init' issue after python is removed
Remove ext/python/bin from PATH to avoid using the Python version from HAWQ.
Remove the library path lib/python/pygresql from PYTHONPATH.
Otherwise 'hawq init' might not find proper Python libraries.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xinzweb/incubator-hawq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
----
commit f292f326528c90287e24cc7cc5687202424b2cb9
Author: Xin Zhang <xz...@pivotal.io>
Date: 2016-01-07T19:07:41Z
Fix 'hawq init' issue after Python is removed.
Remove ext/python/bin from PATH to avoid using the Python version from HAWQ.
Remove the library path lib/python/pygresql from PYTHONPATH.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by xinzweb <gi...@git.apache.org>.
Github user xinzweb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/252#issuecomment-171127544
pygresql should be located under hawq-db-devel/lib/python/pygresql. Let me check the env.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/252#issuecomment-170061090
Will this fix work also for rehl? I thought it was needed in order to make sure we run with the right version of python.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by xinzweb <gi...@git.apache.org>.
Github user xinzweb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/252#issuecomment-171120286
Let me follow up. Sorry, I don't know what caused 'close' of this PR, maybe due to the upgrade on my fork.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by xinzweb <gi...@git.apache.org>.
Github user xinzweb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by vraghavan78 <gi...@git.apache.org>.
Github user vraghavan78 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/252#issuecomment-169861221
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/252#issuecomment-170088630
In that case, should we also remove the reference to python in the DYLD_LIBRARY_PATH?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by xinzweb <gi...@git.apache.org>.
Github user xinzweb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/252#issuecomment-170102062
Yes good catch. I removed, and test it works. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/252#issuecomment-171020495
I have just found out that pygresql (and unittest2) modules are not in the python path.
It is easily reproduced when running the new minirepo command.
So it seems that in addition to installing these components we also need to add them to the path used by python.
```
minirepro
Traceback (most recent call last):
File "/Users/nhorn/dev/hawq/hawq-db-devel/bin/minirepro", line 24, in <module>
from pygresql import pgdb
ImportError: cannot import name pgdb
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Fix 'hawq init' issue after python is...
Posted by xinzweb <gi...@git.apache.org>.
Github user xinzweb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/252#issuecomment-170086039
Good question, and I am sorry I don't have resource to test that scenario. I rely on the build automation on all different flavor of OSs to pass.
All the fix is to 'remove' the lingering python references in the Makefiles, so that if we build on OSX, we can have proper reference of the python pre-installed on the box, other than the one comes with the HAWQ.
Again, the build process should now able to install all the python dependencies before the build. Actually, those should be factored in as part of 'configure' on the 'apache-hawq' part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---