You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/27 12:28:30 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
kgabryje opened a new pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445
### SUMMARY
Fixes https://github.com/apache/incubator-superset/issues/11379. When a user pastes text into the input field, the behaviour is the same as when the user types normally - a dropdown with suggestions appears.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see the screenshots in https://github.com/apache/incubator-superset/issues/11379.
After: I pasted "gen" and as expected, "gender" was suggested. The metric "gender" was correctly added after clicking. THen I pasted "test_metric" and as expected, there was no match.
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/incubator-superset/issues/11379
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8ee649323375d074b5d22b2e7e1f51e0183fe476?el=desc) will **decrease** coverage by `9.65%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.64% 56.99% -9.66%
==========================================
Files 861 408 -453
Lines 40943 13668 -27275
Branches 3694 3481 -213
==========================================
- Hits 27287 7790 -19497
+ Misses 13559 5716 -7843
- Partials 97 162 +65
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.99% <33.33%> (+0.08%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `68.26% <0.00%> (-9.41%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `76.60% <16.66%> (-13.09%)` | :arrow_down: |
| [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | `19.04% <100.00%> (-76.20%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| ... and [682 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [8ee6493...70d86c6](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.64%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 61.97% -4.65%
==========================================
Files 873 420 -453
Lines 41870 26194 -15676
Branches 3847 0 -3847
==========================================
- Hits 27894 16234 -11660
+ Misses 13875 9960 -3915
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `61.97% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.98% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.50% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupClient.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50Lmpz) | | |
| [...et-frontend/src/dashboard/util/isDashboardEmpty.ts](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkRW1wdHkudHM=) | | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | | |
| ... and [450 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d4fd08d](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-718008571
@ktmud I'm having some troubles with implementing what you proposed. If the pasted value contains both incorrect and correct metric names, let's say `gender, test1, ds, test2`, gender and ds metric options are created correctly, but then the input loses focus due to re-render and it's cleared. So the actual result is that we created options `gender` and `ds` and discarded other values. Also, I'm not sure how to handle auto-openning popups when more than 1 option is created.
Do you have any idea for a workaround?
Another case is when there's more than 1 incorrect text - I think that when user pastes `test1, test2, test3` (comma is a separator), we should actually paste either the first or the last item so that we can display dropdown with suggestions. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r517560786
##########
File path: superset-frontend/src/components/Select/OnPasteSelect.jsx
##########
@@ -75,8 +75,8 @@ export default class OnPasteSelect extends React.Component {
}
render() {
- const { selectWrap: SelectComponent, ...restProps } = this.props;
- return <SelectComponent {...restProps} onPaste={this.onPaste} />;
+ const { selectWrap: SelectComponent, onPaste, ...restProps } = this.props;
+ return <SelectComponent {...restProps} onPaste={onPaste || this.onPaste} />;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-718008571
@ktmud I'm having some troubles with implementing what you proposed. If the pasted value contains both incorrect and correct metric names, let's say `gender, test1, ds, test2`, gender and ds metric options are created correctly, but then the input loses focus due to re-render and it's cleared. So the actual result is that we created options `gender` and `ds` and discarded other values. Do you have any idea for a workaround?
Also, I'm not sure how to handle auto-openning popups when more than 1 option is created.
Another case is when there's more than 1 incorrect text - I think that when user pastes `test1, test2, test3` (comma is a separator), we should actually paste either the first or the last item so that we can display dropdown with suggestions. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.25%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 62.36% -4.26%
==========================================
Files 873 875 +2
Lines 41870 42034 +164
Branches 3847 3910 +63
==========================================
- Hits 27894 26213 -1681
- Misses 13875 15639 +1764
- Partials 101 182 +81
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.70% <83.33%> (+0.11%)` | :arrow_up: |
| python | `62.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (-17.48%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.96% <83.33%> (-3.74%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [194 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d4fd08d](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r513000795
##########
File path: superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -275,6 +275,7 @@ export default class AdhocFilterControl extends React.Component {
clearable
closeOnSelect
onChange={this.onChange}
+ onPaste={() => {}}
Review comment:
I also wouldn't worry about `NO_OP` that much as I'm yet to see it causing any real performance issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717557540
I think the original intent of `OnPasteSelect` is to automatically add new options when users pasted valid metrics or column names.
We can either stop supporting `onPaste` for AdhocMetric and AdhocFilter like this PR does, or if we want to continue the support, I think the expected behaviors can be implemented as such:
1. Split the pasted text by by `OnPasteSelect.props.separator`, get candidate metric/column name list `pastingItems`
2. For each item in `pastingItems`, do the following:
1. If it's a valid metric/column name, create a selected option that appends to current selection
2. If it's not valid, keep the text in `invalidInputText`
3. If `invalidInputText` is not empty, set it as `inputText` for the select control.
3. If there are updates to the updated input, call `onChange` event with the updated input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8ee649323375d074b5d22b2e7e1f51e0183fe476?el=desc) will **decrease** coverage by `10.31%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
===========================================
- Coverage 66.64% 56.32% -10.32%
===========================================
Files 861 408 -453
Lines 40943 13668 -27275
Branches 3694 3481 -213
===========================================
- Hits 27287 7699 -19588
+ Misses 13559 5799 -7760
- Partials 97 170 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.32% <33.33%> (-0.58%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `68.26% <0.00%> (-9.41%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `76.60% <16.66%> (-13.09%)` | :arrow_down: |
| [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | `19.04% <100.00%> (-76.20%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-89.19%)` | :arrow_down: |
| [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| ... and [684 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [8ee6493...70d86c6](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r513000516
##########
File path: superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -275,6 +275,7 @@ export default class AdhocFilterControl extends React.Component {
clearable
closeOnSelect
onChange={this.onChange}
+ onPaste={() => {}}
Review comment:
`() => {}` doesn't really return an empty object. It's equivalent to `() => { return }`.
<img src="https://user-images.githubusercontent.com/335541/97356668-d46afc00-1855-11eb-9cd2-2f6f98a55122.png" width="300">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.46%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 62.15% -4.47%
==========================================
Files 873 873
Lines 41870 41870
Branches 3847 3849 +2
==========================================
- Hits 27894 26023 -1871
- Misses 13875 15667 +1792
- Partials 101 180 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.59% <87.50%> (+<0.01%)` | :arrow_up: |
| python | `61.88% <ø> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (-17.48%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.96% <83.33%> (-3.74%)` | :arrow_down: |
| [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | `95.23% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d6d51a0](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-720539859
@ktmud Good point, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.33%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 62.28% -4.34%
==========================================
Files 873 873
Lines 41870 41870
Branches 3847 3849 +2
==========================================
- Hits 27894 26078 -1816
- Misses 13875 15612 +1737
- Partials 101 180 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.59% <87.50%> (+<0.01%)` | :arrow_up: |
| python | `62.09% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (-17.48%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.96% <83.33%> (-3.74%)` | :arrow_down: |
| [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | `95.23% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d6d51a0](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-721638907
@ktmud Do you think we can merge it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r517544563
##########
File path: superset-frontend/src/components/Select/OnPasteSelect.jsx
##########
@@ -75,8 +75,8 @@ export default class OnPasteSelect extends React.Component {
}
render() {
- const { selectWrap: SelectComponent, ...restProps } = this.props;
- return <SelectComponent {...restProps} onPaste={this.onPaste} />;
+ const { selectWrap: SelectComponent, onPaste, ...restProps } = this.props;
+ return <SelectComponent {...restProps} onPaste={onPaste || this.onPaste} />;
Review comment:
Can we revert the change here since it's not needed anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-718008571
@ktmud I'm having some troubles with implementing what you proposed. If the pasted text contains both incorrect and correct metric names, let's say `gender, test1, ds, test2`, gender and ds metric options are created correctly, but then the input loses focus due to re-render and it's cleared. So the actual result is that we created options `gender` and `ds` and discarded other values. Also, I'm not sure how to handle auto-openning popups when more than 1 option is created.
Do you have any idea for a workaround?
Another case is when there's more than 1 incorrect text - I think that when user pastes `test1, test2, test3` (comma is a separator), we should actually paste either the first or the last item so that we can display dropdown with suggestions. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r513436777
##########
File path: superset-frontend/src/components/Select/OnPasteSelect.jsx
##########
@@ -75,8 +75,8 @@ export default class OnPasteSelect extends React.Component {
}
render() {
- const { selectWrap: SelectComponent, ...restProps } = this.props;
- return <SelectComponent {...restProps} onPaste={this.onPaste} />;
+ const { selectWrap: SelectComponent, onPaste, ...restProps } = this.props;
+ return <SelectComponent {...restProps} onPaste={onPaste || this.onPaste} />;
Review comment:
`OnPasteSelect` is also used in `visualizations/FilterBox` and in `explore/components/SelectControl`. I did not analyse these use cases and assumed that `this.onPaste` works as expected there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.29%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 62.32% -4.30%
==========================================
Files 873 873
Lines 41870 41870
Branches 3847 3849 +2
==========================================
- Hits 27894 26094 -1800
- Misses 13875 15596 +1721
- Partials 101 180 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.59% <87.50%> (+<0.01%)` | :arrow_up: |
| python | `62.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (-17.48%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.96% <83.33%> (-3.74%)` | :arrow_down: |
| [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | `95.23% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d6d51a0](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.02%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 62.59% -4.03%
==========================================
Files 873 453 -420
Lines 41870 15676 -26194
Branches 3847 3849 +2
==========================================
- Hits 27894 9813 -18081
+ Misses 13875 5683 -8192
- Partials 101 180 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.59% <87.50%> (+<0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (-17.48%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.96% <83.33%> (-3.74%)` | :arrow_down: |
| [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | `95.23% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [600 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d6d51a0](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r513157852
##########
File path: superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -275,6 +275,7 @@ export default class AdhocFilterControl extends React.Component {
clearable
closeOnSelect
onChange={this.onChange}
+ onPaste={() => {}}
Review comment:
ah yeah, you're totally right. I was mistaken from this eslint rule: https://eslint.org/docs/rules/no-empty-function where they preferred `() => undefined` as it's more obvious that the function is meant to be empty.
That said, it looks like we've defined noOp in a utils file already, so we should probably use that: https://github.com/apache/incubator-superset/blob/ccfd293227105ae1a5a24999a3b75e3db724273b/superset-frontend/src/utils/common.js#L139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.26%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 62.35% -4.27%
==========================================
Files 873 875 +2
Lines 41870 42034 +164
Branches 3847 3910 +63
==========================================
- Hits 27894 26212 -1682
- Misses 13875 15640 +1765
- Partials 101 182 +81
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.70% <83.33%> (+0.11%)` | :arrow_up: |
| python | `62.15% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (-17.48%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.96% <83.33%> (-3.74%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [195 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d4fd08d](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.37%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 62.24% -4.38%
==========================================
Files 873 875 +2
Lines 41870 42034 +164
Branches 3847 3910 +63
==========================================
- Hits 27894 26166 -1728
- Misses 13875 15686 +1811
- Partials 101 182 +81
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.70% <83.33%> (+0.11%)` | :arrow_up: |
| python | `61.97% <ø> (-0.18%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (-17.48%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.96% <83.33%> (-3.74%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [200 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d4fd08d](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r512820844
##########
File path: superset-frontend/src/components/Select/OnPasteSelect.jsx
##########
@@ -75,8 +75,8 @@ export default class OnPasteSelect extends React.Component {
}
render() {
- const { selectWrap: SelectComponent, ...restProps } = this.props;
- return <SelectComponent {...restProps} onPaste={this.onPaste} />;
+ const { selectWrap: SelectComponent, onPaste, ...restProps } = this.props;
+ return <SelectComponent {...restProps} onPaste={onPaste || this.onPaste} />;
Review comment:
why are we keeping around the old `this.onPaste` code? Is that actually used anywhere? Since we're adding an empty function in `AdhocFilterControl`, that will actually override the original behavior, right?
##########
File path: superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -275,6 +275,7 @@ export default class AdhocFilterControl extends React.Component {
clearable
closeOnSelect
onChange={this.onChange}
+ onPaste={() => {}}
Review comment:
Instead of defining this inline, can you define it as a constant NO_OP function above? Better yet, see if we have a NO_OP function exported from a utils file somewhere to use here.
Finally, I think `() => undefined` is prefered to `() => {}` as it doesn't construct an empty object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `5.46%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 61.15% -5.47%
==========================================
Files 873 420 -453
Lines 41870 26183 -15687
Branches 3847 0 -3847
==========================================
- Hits 27894 16012 -11882
+ Misses 13875 10171 -3704
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `61.15% <ø> (-1.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.94% <0.00%> (-6.02%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d4fd08d](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717236011
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=h1) Report
> Merging [#11445](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f2e36dd1b63adc252485801ab1673ecf621dffa?el=desc) will **decrease** coverage by `4.33%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 66.62% 62.28% -4.34%
==========================================
Files 873 873
Lines 41870 41870
Branches 3847 3849 +2
==========================================
- Hits 27894 26079 -1815
- Misses 13875 15611 +1736
- Partials 101 180 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.59% <87.50%> (+<0.01%)` | :arrow_up: |
| python | `62.09% <ø> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.19% <ø> (-17.48%)` | :arrow_down: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `85.96% <83.33%> (-3.74%)` | :arrow_down: |
| [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | `95.23% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/11445/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=footer). Last update [6f2e36d...d6d51a0](https://codecov.io/gh/apache/incubator-superset/pull/11445?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717213132
@zuzana-vej Is that how we expect it to work? This feature might have been broken for at least 5 months, as the last meaningful change to the offending component was done in May 2020 (and I'm not sure if that change was responsible for the bug).
@rusackas Can you please take a look?
CC: @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#discussion_r513537963
##########
File path: superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -275,6 +275,7 @@ export default class AdhocFilterControl extends React.Component {
clearable
closeOnSelect
onChange={this.onChange}
+ onPaste={() => {}}
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on pull request #11445: fix: Pasting text issues in MetricsControl and AdhocFilterControl inputs
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on pull request #11445:
URL: https://github.com/apache/incubator-superset/pull/11445#issuecomment-717331347
Hi @kgabryje Thanks for the details and video. I believe this is the expected behavior. I don't think this feature is used too frequently and not everyone always reports bugs, so it's certainly possible it's been around for a while.
cc @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org