[GitHub] [iotdb] neuyilan commented on a change in pull request #2423: Remove EnvironmentUtil in the cluster module and optimize UT

[GitBox <gi...@apache.org>]

neuyilan commented on a change in pull request #2423:
URL: https://github.com/apache/iotdb/pull/2423#discussion_r552359393



##########
File path: cluster/src/test/java/org/apache/iotdb/cluster/server/member/MemberTest.java
##########
@@ -149,6 +156,7 @@ public void setUp() throws Exception {
 
     testMetaMember.setPartitionTable(partitionTable);
     MetaPuller.getInstance().init(testMetaMember);
+    logger.warn("Member test set up");

Review comment:
       Why use the warn log here?

##########
File path: server/src/main/java/org/apache/iotdb/db/query/control/QueryFileManager.java
##########
@@ -119,6 +121,9 @@ void addFilePathToMap(long queryId, TsFileResource tsFile, boolean isClosed) {
     if (!pathMap.get(queryId).contains(tsFile)) {
       pathMap.get(queryId).add(tsFile);
       FileReaderManager.getInstance().increaseFileReaderReference(tsFile, isClosed);
+      logger.warn("{} is read-locked by {}", tsFile, queryId, new Exception());

Review comment:
       Is this a debug log? Why print the exception?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org