You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "lyne7-sc (via GitHub)" <gi...@apache.org> on 2026/08/31 07:49:28 UTC
[PR] fix: aggregate dynamic filtering with unsupported expressions [datafusion]
lyne7-sc opened a new pull request, #24817:
URL: https://github.com/apache/datafusion/pull/24817
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #24816.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the
implementation. "COUNT(DISTINCT) returns wrong results when the column contains
nulls" is the user-visible problem.
-->
Aggregate dynamic filtering currently ignores unsupported expressions while still generating a shared scan predicate from supported aggregates. This can prune rows required by the unsupported aggregate and produce incorrect results.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Disable aggregate dynamic filtering when any aggregate expression is unsupported.
- Document that aggregate dynamic filtering requires every aggregate expression to be supported.
- Update the existing sqllogictest to verify that no dynamic filter is produced for mixed supported and unsupported expressions.
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised.
-->
Yes. Updated the existing sqllogictest case in `push_down_filter_regression.slt`.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api change` label.
-->
Yes. This fixes potentially incorrect query results. No API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: aggregate dynamic filtering with unsupported expressions [datafusion]
Posted by "lyne7-sc (via GitHub)" <gi...@apache.org>.
lyne7-sc commented on code in PR #24817:
URL: https://github.com/apache/datafusion/pull/24817#discussion_r3951059354
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -778,10 +779,10 @@ struct AggrDynFilter {
/// The current bounds for the dynamic filter, updates during the execution to
/// tighten the bound for more effective pruning.
///
- /// Each vector element is for the accumulators that support dynamic filter.
- /// e.g. This `AggregateExec` has accumulator:
- /// min(a), avg(a), max(b)
- /// And this field stores [PerAccumulatorDynFilter(min(a)), PerAccumulatorDynFilter(min(b))]
+ /// Each vector element corresponds to one aggregate expression. Dynamic filtering
+ /// is enabled only when every aggregate expression is supported, so this vector
+ /// contains an entry for every accumulator. For example, `min(a), max(b)` produces
+ /// entries for `min(a)` and `max(b)`.
supported_accumulators_info: Vec<PerAccumulatorDynFilter>,
Review Comment:
Yes, that makes sense to me. renamed to `accumulator_dyn_filter_info`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: aggregate dynamic filtering with unsupported expressions [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on PR #24817:
URL: https://github.com/apache/datafusion/pull/24817#issuecomment-5598248308
🚀
@lyne7-sc
Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: aggregate dynamic filtering with unsupported expressions [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew merged PR #24817:
URL: https://github.com/apache/datafusion/pull/24817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: aggregate dynamic filtering with unsupported expressions [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on code in PR #24817:
URL: https://github.com/apache/datafusion/pull/24817#discussion_r3948330464
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -778,10 +779,10 @@ struct AggrDynFilter {
/// The current bounds for the dynamic filter, updates during the execution to
/// tighten the bound for more effective pruning.
///
- /// Each vector element is for the accumulators that support dynamic filter.
- /// e.g. This `AggregateExec` has accumulator:
- /// min(a), avg(a), max(b)
- /// And this field stores [PerAccumulatorDynFilter(min(a)), PerAccumulatorDynFilter(min(b))]
+ /// Each vector element corresponds to one aggregate expression. Dynamic filtering
+ /// is enabled only when every aggregate expression is supported, so this vector
+ /// contains an entry for every accumulator. For example, `min(a), max(b)` produces
+ /// entries for `min(a)` and `max(b)`.
supported_accumulators_info: Vec<PerAccumulatorDynFilter>,
Review Comment:
Small naming suggestion, not blocking: would it make sense to rename `supported_accumulators_info` to something like `accumulator_dyn_filter_info`? With the new all-or-nothing behavior, this contains metadata for every aggregate whenever dynamic filtering is enabled, so dropping `supported` might make that invariant a little clearer.
##########
datafusion/sqllogictest/test_files/push_down_filter_regression.slt:
##########
@@ -415,15 +413,15 @@ CREATE EXTERNAL TABLE agg_dyn_mixed (a INT, b INT, c INT)
STORED AS PARQUET
LOCATION 'test_files/scratch/push_down_filter_regression/agg_dyn_mixed/';
-# -> DynamicFilter [ a < 1 OR a > 8 OR b > 12 ] (MIN(c+1) dropped as unsupported)
+# No dynamic filter because not every aggregate has a safe predicate.
query TT
EXPLAIN ANALYZE SELECT MIN(a), MAX(a), MAX(b), MIN(c + 1) FROM agg_dyn_mixed;
Review Comment:
Could we add an execution-result assertion here as well? The current `EXPLAIN ANALYZE` assertion confirms that the dynamic filter is absent, but it does not directly verify the correctness issue this change is intended to fix: the unsupported aggregate still needs to see every relevant row.
For this fixture, the expected result for `MIN(a), MAX(a), MAX(b), MIN(c + 1)` is `1, 8, 12, 71`.
It would also be good to make the fixture or scan order deterministic enough that the old behavior actually prunes the row needed by `MIN(c + 1)`. With the current two-file layout, that can depend on which file publishes its bounds first. Ideally, this regression test should fail with the old implementation because it produces the wrong result, rather than only because the plan contains a dynamic filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: aggregate dynamic filtering with unsupported expressions [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24817:
URL: https://github.com/apache/datafusion/pull/24817#issuecomment-5475675341
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/24817?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.53%. Comparing base ([`4b8ad88`](https://app.codecov.io/gh/apache/datafusion/commit/4b8ad880974776b209b9d4e3fc7e899ad7b05eba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`67ea4ee`](https://app.codecov.io/gh/apache/datafusion/commit/67ea4ee00625e52b301f95c554c45a98d9a71b89?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #24817 +/- ##
========================================
Coverage 81.53% 81.53%
========================================
Files 1123 1123
Lines 406042 406284 +242
Branches 406042 406284 +242
========================================
+ Hits 331059 331257 +198
- Misses 55621 55660 +39
- Partials 19362 19367 +5
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/24817?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: aggregate dynamic filtering with unsupported expressions [datafusion]
Posted by "lyne7-sc (via GitHub)" <gi...@apache.org>.
lyne7-sc commented on code in PR #24817:
URL: https://github.com/apache/datafusion/pull/24817#discussion_r3951056280
##########
datafusion/sqllogictest/test_files/push_down_filter_regression.slt:
##########
@@ -415,15 +413,15 @@ CREATE EXTERNAL TABLE agg_dyn_mixed (a INT, b INT, c INT)
STORED AS PARQUET
LOCATION 'test_files/scratch/push_down_filter_regression/agg_dyn_mixed/';
-# -> DynamicFilter [ a < 1 OR a > 8 OR b > 12 ] (MIN(c+1) dropped as unsupported)
+# No dynamic filter because not every aggregate has a safe predicate.
query TT
EXPLAIN ANALYZE SELECT MIN(a), MAX(a), MAX(b), MIN(c + 1) FROM agg_dyn_mixed;
Review Comment:
Good point. I've added a result check and adjusted the test data so the old implementation produces the wrong result. The test passes with the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org