You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hudi.apache.org by lamberken <la...@163.com> on 2019/11/25 17:56:50 UTC

[Discuss] Migrate from log4j to slf4j

Hi, everyone


Currently, there are three kinds of java logging framework in hudi's project (java.util.logging.Logger、org.apache.log4j.Logger、org.slf4j.Logger).


The org.apache.log4j.Logger doesn't support placeholders, so it‘s hard for us to format the message like 
| logger.info(String.format("The job needs to copy %d partitions.", partitions.size())); |


So, I suggest migrate from log4j to slf4j, what dou you think? 


Best,
lamberken

Re:Re: [Discuss] Migrate from log4j to slf4j

Posted by lamberken <la...@163.com>.

Thanks, 


I don't know there is a JIRA for this already(HUDI-233). We can talk about it under that issue.


Best,
lamberken


At 2019-11-26 03:09:40, "Vinoth Chandar" <vi...@apache.org> wrote:
>Hi,
>
>Its log4j actually across the board. (I think there are a couple files that
>have non log4j loggers? might be good to fix  to log4j as well for now to
>be consistent)
>
>Nonetheless, there is a JIRA for this already
>https://issues.apache.org/jira/browse/HUDI-233
>
>Main thing we need to be mindful of is to ensure all the shading and
>everything works properly across the bundles.
>
>On Mon, Nov 25, 2019 at 9:57 AM lamberken <la...@163.com> wrote:
>
>> Hi, everyone
>>
>>
>> Currently, there are three kinds of java logging framework in hudi's
>> project (java.util.logging.Logger、org.apache.log4j.Logger、org.slf4j.Logger).
>>
>>
>> The org.apache.log4j.Logger doesn't support placeholders, so it‘s hard for
>> us to format the message like
>> | logger.info(String.format("The job needs to copy %d partitions.",
>> partitions.size())); |
>>
>>
>> So, I suggest migrate from log4j to slf4j, what dou you think?
>>
>>
>> Best,
>> lamberken

Re: [Discuss] Migrate from log4j to slf4j

Posted by Vinoth Chandar <vi...@apache.org>.

Hi,

Its log4j actually across the board. (I think there are a couple files that
have non log4j loggers? might be good to fix  to log4j as well for now to
be consistent)

Nonetheless, there is a JIRA for this already
https://issues.apache.org/jira/browse/HUDI-233

Main thing we need to be mindful of is to ensure all the shading and
everything works properly across the bundles.

On Mon, Nov 25, 2019 at 9:57 AM lamberken <la...@163.com> wrote:

> Hi, everyone
>
>
> Currently, there are three kinds of java logging framework in hudi's
> project (java.util.logging.Logger、org.apache.log4j.Logger、org.slf4j.Logger).
>
>
> The org.apache.log4j.Logger doesn't support placeholders, so it‘s hard for
> us to format the message like
> | logger.info(String.format("The job needs to copy %d partitions.",
> partitions.size())); |
>
>
> So, I suggest migrate from log4j to slf4j, what dou you think?
>
>
> Best,
> lamberken