You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/09 13:44:38 UTC
[GitHub] [incubator-dolphinscheduler] whw02 opened a new issue #4757: [Bug][server] failoverWorker 容错
whw02 opened a new issue #4757:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4757
分支：dev
测试中发现dolphinscheduler-server模块中关于ZKMasterClient中failoverWorker方法中查询需要容错的任务实例时，入参workerHost并不是ip地址加端口号
根据打印的日志显示如下:
从而导致查询不到数据库中的需要容错任务实例，不能完成容错机制。同理failoverMaster也存在这样的问题。
不知是否是我配置问题，还是什么原因。谢谢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen commented on issue #4757: [Bug][server] failoverWorker 容错
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on issue #4757:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4757#issuecomment-779295830
@dailidong @zhuangchong @CalvinKirs
This issue is caused by calculating the warm-up time of load balancing, see
[code 1](https://github.com/apache/incubator-dolphinscheduler/blob/5f40fce1f5544baffe34356e4244aaf0b364fd83/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java#L162)
[code 2](https://github.com/zt-1997/incubator-dolphinscheduler/blob/8aae5b599b9f7437e4f1e0dd365d62f86d9f03b1/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/WorkerGroupService.java#L170)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #4757: [Bug][server] failoverWorker 容错
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #4757:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4757#issuecomment-778107600
as a global project, please update/add title and description in English, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #4757: [Bug][server] failoverWorker 容错
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #4757:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4757#issuecomment-779274502
Worker failover does have problems, while Master failover is normal,I will fix the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #4757: [Bug][server] failoverWorker 容错
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #4757:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4757#issuecomment-779539449
> Maybe host + timestamp is used in business use (it may be used in too many scenarios, we don't need to distinguish it), but in the final interaction with the database, do a layer of conversion, (remove the timestamp) what do you think.
I think it's OK to do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen edited a comment on issue #4757: [Bug][server] failoverWorker 容错
Posted by GitBox <gi...@apache.org>.
chengshiwen edited a comment on issue #4757:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4757#issuecomment-779295830
@dailidong @zhuangchong @CalvinKirs
This issue is caused by calculating the warm-up time of load balancing, see
- [code 1](https://github.com/apache/incubator-dolphinscheduler/blob/5f40fce1f5544baffe34356e4244aaf0b364fd83/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java#L162)
- [code 2](https://github.com/zt-1997/incubator-dolphinscheduler/blob/8aae5b599b9f7437e4f1e0dd365d62f86d9f03b1/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/WorkerGroupService.java#L170)
Similar problems always exist wherever the timestamp suffix needs to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on issue #4757: [Bug][server] failoverWorker 容错
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #4757:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4757#issuecomment-779304953
Maybe host + timestamp is used in business use (it may be used in too many scenarios, we don't need to distinguish it), but in the final interaction with the database, do a layer of conversion, (remove the timestamp) what do you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs closed issue #4757: [Bug][server] failoverWorker 容错
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #4757:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/4757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org