[GitHub] [ratis] szetszwo commented on pull request #713: RATIS-1638. Separate first election timeout

[GitBox <gi...@apache.org>]

szetszwo commented on PR #713:
URL: https://github.com/apache/ratis/pull/713#issuecomment-1219728245

   > . In that case, what's the meaning of using fallbackKey or fallbackValue?
   
   @SzyWilliam , Good catch!  It is a bug.  It should be
   ```java
   @@ -236,10 +247,11 @@ public interface ConfUtils {
        T value = get(getter, key, defaultValue, null, assertions);
        if (value != defaultValue) {
          logGet(key, value, defaultValue, logger);
   +      return value;
        } else {
          logFallback(key, fallbackKey, fallbackValue, logger);
   +      return fallbackValue;
        }
   -    return value;
      }
   ```
   Could you include it in this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org